Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-35854: etcd_unique_ca bundle path for OCP 4.17 #12320

Merged

Conversation

yuumasato
Copy link
Member

Description:

  • Make the filepath for the CA bundle certs a regular expression matching the path for OCP <= 4.16 and OCP >= 4.17.

Rationale:

  • In OCP 4.17 the ca bundle certs were relocated, lets update the bundle filepath to match it as well.
    This keeps the rule compatible with all supported OCP versions without need to add a new rule, or object and test.

  • Fixes OCPBUGS-35854

In OCP 4.17 the ca bundle certs were relocated, lets update the bundle
filepath to match it as well.
This keeps the rule compatible with all supported OCP versions without
need to add a new rule, or object and test.
@yuumasato yuumasato added OpenShift OpenShift product related. CIS CIS Benchmark related. labels Aug 21, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

ocp4 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12320
This image was built from commit: b729e0b

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12320

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12320 make deploy-local

Copy link

codeclimate bot commented Aug 21, 2024

Code Climate has analyzed commit b729e0b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@yuumasato
Copy link
Member Author

/test 4.16-e2e-aws-ocp4-cis-node
/test 4.17-e2e-aws-ocp4-cis-node

Copy link

openshift-ci bot commented Aug 21, 2024

@yuumasato: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.17-e2e-aws-ocp4-cis-node b729e0b link true /test 4.17-e2e-aws-ocp4-cis-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhmdnd rhmdnd added this to the 0.1.75 milestone Aug 21, 2024
Copy link
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rhmdnd
Copy link
Collaborator

rhmdnd commented Aug 21, 2024

The 4.17 failures were unrelated, but the etcd-unique-ca rule passed as expectedon 4.16 and 4.17.

@rhmdnd rhmdnd merged commit feda873 into ComplianceAsCode:master Aug 22, 2024
95 of 100 checks passed
@xiaojiey
Copy link
Collaborator

Verification pass. Details seen from the Jira ticket.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants