Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slmicro5 stig add audit rules dac/usergroup modification based rules support #12278

Conversation

svet-se
Copy link
Contributor

@svet-se svet-se commented Aug 7, 2024

Description:

  • Add rules based on audit rules dac/usergroup modification template to SLE Micro 5 STIG profile

Rationale:

  • According to DISA SLE Micro 5 STIG Version 1, Release: 1 Benchmark Date: 13 Jun 2024

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Aug 7, 2024
Copy link

openshift-ci bot commented Aug 7, 2024

Hi @svet-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented Aug 7, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Aug 7, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12278
This image was built from commit: aacd201

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12278

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12278 make deploy-local

@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Aug 11, 2024
@svet-se svet-se force-pushed the slmicro5-stig-add-audit-rules-dac-modification-based-rules-support branch from 0a6cb78 to e9c38b6 Compare August 12, 2024 10:33
@openshift-merge-robot openshift-merge-robot added needs-rebase Used by openshift-ci bot. and removed needs-rebase Used by openshift-ci bot. labels Aug 12, 2024
@svet-se svet-se force-pushed the slmicro5-stig-add-audit-rules-dac-modification-based-rules-support branch from e9c38b6 to eb301a7 Compare August 14, 2024 06:43
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Aug 14, 2024
@teacup-on-rockingchair teacup-on-rockingchair added the SLES SUSE Linux Enterprise Server product related. label Aug 14, 2024
@teacup-on-rockingchair teacup-on-rockingchair added this to the 0.1.75 milestone Aug 14, 2024
@teacup-on-rockingchair teacup-on-rockingchair force-pushed the slmicro5-stig-add-audit-rules-dac-modification-based-rules-support branch from eb301a7 to 99ffd71 Compare August 20, 2024 04:25
Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@teacup-on-rockingchair teacup-on-rockingchair force-pushed the slmicro5-stig-add-audit-rules-dac-modification-based-rules-support branch from 99ffd71 to aacd201 Compare August 27, 2024 05:58
Copy link

codeclimate bot commented Aug 27, 2024

Code Climate has analyzed commit aacd201 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@teacup-on-rockingchair teacup-on-rockingchair merged commit 2f91910 into ComplianceAsCode:master Aug 27, 2024
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants