Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rhel7 only rules #12112

Merged
merged 7 commits into from
Jul 4, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jul 1, 2024

Description:

Remove rules that where only used in RHEL 7.

Rationale:

Clean up rules that are no longer needed.

Review Hints:

The script in #12110 maybe useful for review.

@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Jul 1, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone Jul 1, 2024
Copy link

github-actions bot commented Jul 1, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jul 1, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12112
This image was built from commit: aed4315

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12112

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12112 make deploy-local

Copy link

codeclimate bot commented Jul 1, 2024

Code Climate has analyzed commit aed4315 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@steveandreassend
Copy link

It was helpful having RHEL7 coverage. RedHat has just announced they are offering 3 year extended support for this release because the installed base continues to remain on this release.

@Mab879
Copy link
Member Author

Mab879 commented Jul 3, 2024

It was helpful having RHEL7 coverage. RedHat has just announced they are offering 3 year extended support for this release because the installed base continues to remain on this release.

Thanks for your comment. The RHEL 7 content in RHEL 7 isn't going anywhere. It will be there for the reminder of the EUS period. Please use the content from the scap-security-guide package to use the content created by this project. However due to agencies like CIS stopping updates at the end of the maintenance on 30 June 2024, Red Hat stopped updating the compliance content for RHEL 7 on 30 June 2024, see this blog post from the Red Hat blog for more details. Also the RHEL 7 product is already gone from this project see #12093.

@steveandreassend
Copy link

Understood. Having this page was really handy https://complianceascode.github.io/content-pages/tables/table-rhel7-cces.html for quick lookups.

@jan-cerny jan-cerny self-assigned this Jul 4, 2024
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified that these rules aren't used anywhere.

@jan-cerny jan-cerny merged commit df5c505 into ComplianceAsCode:master Jul 4, 2024
94 checks passed
@Mab879 Mab879 deleted the remove_rhel7_only_rules branch July 4, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants