Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-33945: select required SSHD timeout rule #12091

Merged

Conversation

yuumasato
Copy link
Member

Description:

Rationale:

  • Rule requirement alignment in OCP4 high and moderate profiles.

Review Hints:

  • CCRs for sshd_set_idle_timeout appears after ``rhcos4-highorrhcos4-moderate`.

@yuumasato yuumasato requested a review from rhmdnd June 25, 2024 17:02
@yuumasato yuumasato added the OpenShift OpenShift product related. label Jun 25, 2024
@yuumasato
Copy link
Member Author

/test e2e-aws-rhcos4-high
/test e2e-aws-rhcos4-moderate

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jun 25, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12091
This image was built from commit: 53fbc4f

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12091

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12091 make deploy-local

@yuumasato yuumasato force-pushed the sshd_set_timeout_and_keepalive branch from 729a3eb to f386a43 Compare June 26, 2024 09:18
@yuumasato
Copy link
Member Author

/test e2e-aws-rhcos4-high
/test e2e-aws-rhcos4-moderate

1 similar comment
@yuumasato
Copy link
Member Author

/test e2e-aws-rhcos4-high
/test e2e-aws-rhcos4-moderate

The rule sshd_set_idle_timeout used to require rule sshd_set_keepalive_0
for Red Hat linuxes. But after ComplianceAsCode#11815 it started to require rules
sshd_set_keepalive.

This selects the rule that satifyes the requirement.
Add e2e for sshd-set-idle-timeout and replace sshd-set-keepalive-0 with
sshd-set-keepalive.
@yuumasato yuumasato force-pushed the sshd_set_timeout_and_keepalive branch from d0b0aba to 53fbc4f Compare June 27, 2024 14:13
@yuumasato
Copy link
Member Author

/test e2e-aws-rhcos4-high
/test e2e-aws-rhcos4-moderate

Copy link

codeclimate bot commented Jun 27, 2024

Code Climate has analyzed commit 53fbc4f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Copy link
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rhmdnd rhmdnd merged commit 62a499f into ComplianceAsCode:master Jun 28, 2024
94 of 95 checks passed
@yuumasato yuumasato added this to the 0.1.74 milestone Jun 28, 2024
@yuumasato yuumasato deleted the sshd_set_timeout_and_keepalive branch June 28, 2024 13:47
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenShift OpenShift product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants