Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes debian #12084

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes debian #12084

wants to merge 3 commits into from

Conversation

a-skr
Copy link
Contributor

@a-skr a-skr commented Jun 20, 2024

Description:

  • update debian12 profiles
  • update a chronyd rule to handle debian /etc sub-directories organization.
  • fix a regex in sysctl template

Copy link

openshift-ci bot commented Jun 20, 2024

Hi @a-skr. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jun 20, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jun 20, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12084
This image was built from commit: 161b206

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12084

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12084 make deploy-local

@@ -15,7 +15,7 @@

<ind:textfilecontent54_object comment="Ensure at least one NTP server is set"
id="object_chronyd_remote_server" version="1">
<ind:filepath operation="pattern match">^/etc/chrony\.(conf|d/.+\.conf)$</ind:filepath>
<ind:filepath operation="pattern match">^/etc/(?:chrony/)?chrony\.(conf|d/.+\.conf)$</ind:filepath>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be reworked to use product properties chrony_conf_path and chrony_d_path correctly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit has been amended accordingly.

@marcusburghardt marcusburghardt added the Debian Debian product related. label Jul 1, 2024
@marcusburghardt marcusburghardt requested a review from a team July 1, 2024 07:12
@marcusburghardt marcusburghardt added this to the 0.1.74 milestone Jul 1, 2024
Copy link

codeclimate bot commented Jul 4, 2024

Code Climate has analyzed commit 161b206 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Debian Debian product related. needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants