OCP4: deprecating two api_server rules #11758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
|
/test |
|
@rhmdnd: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rhmdnd
reviewed
Mar 26, 2024
Vincent056
force-pushed
the
insecure_port
branch
from
b15acd9
to
9a2e5a2
Compare
|
Thanks for confirming @yuumasato. @Vincent056 - apologies for preemptively suggesting we revert the STIG rule association. This should be all we need, in addition to what's already proposed: diff --git a/controls/srg_ctr/SRG-APP-000516-CTR-001325.yml b/controls/srg_ctr/SRG-APP-000516-CTR-001325.yml
index 7b5d85ddd8..916f315783 100644
--- a/controls/srg_ctr/SRG-APP-000516-CTR-001325.yml
+++ b/controls/srg_ctr/SRG-APP-000516-CTR-001325.yml
@@ -17,7 +17,6 @@ controls:
- api_server_admission_control_plugin_service_account
- api_server_anonymous_auth
- api_server_api_priority_flowschema_catch_all
- - api_server_api_priority_gate_enabled
- api_server_audit_log_maxbackup
- api_server_audit_log_maxsize
- api_server_audit_log_path
@@ -30,7 +29,6 @@ controls:
- api_server_etcd_key
- api_server_https_for_kubelet_conn
- api_server_insecure_bind_address
- - api_server_insecure_port
- api_server_kubelet_certificate_authority
- api_server_kubelet_client_cert
- api_server_kubelet_client_cert_pre_4_9 |
|
/hold for test |
|
@Vincent056 Seems the annotations also need to be updated. |
Vincent056
force-pushed
the
insecure_port
branch
from
9a2e5a2
to
5ba7eed
Compare
|
@Vincent056 Per the test result, the control.compliance.openshift.io/PCI-DSS and policies.open-cluster-management.io/standards for rule upstream-ocp4-api-server-api-priority-gate-enabled should also be removed. Besides, could you please also update status in OCPBUGS-34982? Thanks. |
|
@Vincent056 I think you need to rebase this PR. More profiles select these rules on latest master. |
|
ping |
Vincent056
force-pushed
the
insecure_port
branch
from
5ba7eed
to
f3764e3
Compare
|
@Vincent056 Should the PCI-DSS control info get removed from the annotations? I didn't find the rule api-server-api-priority-gate-enabled in pci-dss profile. |
xiaojiey
reviewed
Aug 12, 2024
applications/openshift/api-server/api_server_api_priority_gate_enabled/rule.yml
Outdated
Show resolved
Hide resolved
rhmdnd
reviewed
Aug 12, 2024
applications/openshift/api-server/api_server_api_priority_gate_enabled/rule.yml
Outdated
Show resolved
Hide resolved
yuumasato
reviewed
Aug 13, 2024
applications/openshift/api-server/api_server_api_priority_gate_enabled/rule.yml
Outdated
Show resolved
Hide resolved
…_insecure_port This pr remove api_server_insecure_port and api_server_api_priority_gate_enabled from any of the OCP profiles, becuase we no longer support those applicable OCP versions.
Vincent056
force-pushed
the
insecure_port
branch
from
f3764e3
to
f4bcb76
Compare
|
Code Climate has analyzed commit f4bcb76 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
|
/retest |
yuumasato
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr removes
api_server_insecure_portandapi_server_api_priority_gate_enabledfrom any of the OCP profiles because we no longer support those applicable OCP versions.