Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ansible remediation for audispd plugin UBTU-20-010216 #11093

Conversation

dexterle
Copy link
Contributor

@dexterle dexterle commented Sep 8, 2023

Description:

  • Fix UBTU-20-010216
  • Add Ansible remediation for Ubuntu

Rationale:

Review Hints:

Build the product:

./build_product ubuntu2004

To test these changes with Ansible:

ansible-playbook build/ansible/ubuntu2004-playbook-stig.yml --tags "DISA-STIG-UBTU-20-010216"

To test changes with bash, run the remediation sections: xccdf_org.ssgproject.content_rule_auditd_audispd_configure_remote_server

Checkout Manual STIG OVAL definitions, and use software like DISA STIG Viewer to view definitions.

git checkout dexterle:add-manual-stig-ubtu-20-v1r9

This STIG can not be tested with the latest Ubuntu 2004 Benchmark SCAP. Please perform a manual check given the check text. For reference, please review the latest artifacts: https://public.cyber.mil/stigs/downloads/

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Used by openshift-ci bot. needs-ok-to-test Used by openshift-ci bot. labels Sep 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 8, 2023

Hi @dexterle. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Mab879 Mab879 added Ubuntu Ubuntu product related. STIG STIG Benchmark related. labels Sep 8, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@dexterle dexterle marked this pull request as ready for review September 11, 2023 16:57
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Sep 11, 2023
@dodys dodys self-assigned this Sep 12, 2023
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the bash remediation is shared, so should the ansible.

@dodys dodys added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Sep 12, 2023
This commit will add in ansible remediation for audispd plugin which also ensures that the plugin is enabled within au-remote.conf.
@dexterle dexterle force-pushed the add-remediation-ubtu-20-010216 branch from eaea06e to f214a16 Compare September 28, 2023 15:30
@codeclimate
Copy link

codeclimate bot commented Sep 28, 2023

Code Climate has analyzed commit f214a16 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 56.9%.

View more on Code Climate.

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now you should add the ubuntu specific bits, see bash

@jan-cerny
Copy link
Collaborator

@dexterle @dodys Do you plan to continue working on this PR?

@dodys
Copy link
Contributor

dodys commented Nov 2, 2023

@dexterle @dodys Do you plan to continue working on this PR?

I sent a message to dexterle on gitter last week to get some feedback, if we don't hear anything until November 13th, then we will start adding the missing bits on top of the open PRs.

@vojtapolasek vojtapolasek added this to the 0.1.72 milestone Nov 29, 2023
@aghassemlouei
Copy link
Contributor

@dodys I was able to get in touch with a colleague who more recently spoke with @dexterle and they mentioned that they are focusing on other personal matters so if you all wouldn't mind helping taking the handful of open pull requests to the finish line I'd really appreciate it. Unfortunately these days I don't have any time to help personally but will continue to direct folks to help out.

It's also worth noting that I have been doing my best to get vendors to contribute directly and have seen some success with SUSE so I'm focused on Canonical this next year.

@dodys
Copy link
Contributor

dodys commented Dec 1, 2023

@dodys I was able to get in touch with a colleague who more recently spoke with @dexterle and they mentioned that they are focusing on other personal matters so if you all wouldn't mind helping taking the handful of open pull requests to the finish line I'd really appreciate it. Unfortunately these days I don't have any time to help personally but will continue to direct folks to help out.

It's also worth noting that I have been doing my best to get vendors to contribute directly and have seen some success with SUSE so I'm focused on Canonical this next year.

thanks for the heads up, I spoke with Dexter a month ago and we will be continuing his work.
@mpurg is currently on it and already provided one PR #11325

@marcusburghardt
Copy link
Member

/packit test

@aghassemlouei
Copy link
Contributor

c

Appreciate your efforts @dodys and @mpurg; as we start ramping back up post-holidays we'll have more engineers contributing and supporting the project.

@marcusburghardt marcusburghardt modified the milestones: 0.1.72, 0.1.73 Jan 29, 2024
@marcusburghardt
Copy link
Member

Could you resolve the conflict, please?

@vojtapolasek vojtapolasek modified the milestones: 0.1.73, 0.1.74 Apr 30, 2024
@Mab879 Mab879 modified the milestones: 0.1.74, 0.1.75 Jul 29, 2024
Copy link

openshift-ci bot commented Jul 30, 2024

@dexterle: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.17-images f214a16 link true /test 4.17-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jan-cerny
Copy link
Collaborator

ping

@dodys
Copy link
Contributor

dodys commented Aug 2, 2024

dexterle reached out last week about continuing work on this PRs, and I've asked to open new ones for a clean state. Therefore closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants