-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable logrotate.timer check on RHCOS4 #11045
Enable logrotate.timer check on RHCOS4 #11045
Conversation
From 4.13 RHCOS4 is based on RHEL9, thus this check can be enabled. On 4.13, the timer for logrotate is enabled by default. And on 4.12 and older, the daily cron job for logrotate is enabled by default.
Code Climate has analyzed commit 5eee3f2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.8% (0.0% change). View more on Code Climate. |
/test help |
@yuumasato: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-aws-rhcos4-high |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description:
logrotate.timer
onrhcos4
.From 4.13 RHCOS4 is based on RHEL9, so this check can be enabled.
Rationale:
Fixes:
ensure_logrotate_activated
result after remediation with compliance-operatorRelated: