-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set package_rng-tools_installed as machine only #10810
Set package_rng-tools_installed as machine only #10810
Conversation
Entropy gathering should be done on the host, not in each container.
Hi @candrews. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This datastream diff is auto generated by the check Click here to see the full diffbash remediation for rule 'xccdf_org.ssgproject.content_rule_package_rng-tools_installed' differs.
--- xccdf_org.ssgproject.content_rule_package_rng-tools_installed
+++ xccdf_org.ssgproject.content_rule_package_rng-tools_installed
@@ -1,4 +1,10 @@
+# Remediation is applicable only in certain platforms
+if [ ! -f /.dockerenv ] && [ ! -f /run/.containerenv ]; then
if ! rpm -q --quiet "rng-tools" ; then
yum install -y "rng-tools"
fi
+
+else
+ >&2 echo 'Remediation is not applicable, nothing was done'
+fi
ansible remediation for rule 'xccdf_org.ssgproject.content_rule_package_rng-tools_installed' differs.
--- xccdf_org.ssgproject.content_rule_package_rng-tools_installed
+++ xccdf_org.ssgproject.content_rule_package_rng-tools_installed
@@ -2,6 +2,7 @@
package:
name: rng-tools
state: present
+ when: ansible_virtualization_type not in ["docker", "lxc", "openvz", "podman", "container"]
tags:
- CCE-82968-9
- DISA-STIG-RHEL-08-010472
Platform has been changed for rule 'xccdf_org.ssgproject.content_rule_package_rng-tools_installed'
--- xccdf_org.ssgproject.content_rule_package_rng-tools_installed
+++ xccdf_org.ssgproject.content_rule_package_rng-tools_installed
@@ -1 +1 @@
-
+oval:ssg-installed_env_is_a_machine:def:1 |
Code Climate has analyzed commit 94849de and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.5% (0.0% change). View more on Code Climate. |
583b2a0
into
ComplianceAsCode:master
Description:
Set package_rng-tools_installed as machine only
Rationale:
Entropy gathering should be done on the host, not in each container.