Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify DispatcherQueueTimer source for XML docs output #4267

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

XAML-Knight
Copy link
Contributor

Fixes 496 in the Docs

The audience is misled into thinking the proper way to initialize a DispatcherQueueTimer is by using new . The PR corrects the code example to show the proper way to initialize a DispatcherQueueTimer. XML doc to be auto-generated with this updated code.

PR Type

What kind of change does this PR introduce?

Bugfix

What is the current behavior?

The audience is misled into thinking the proper way to initialize a DispatcherQueueTimer is by using new .

What is the new behavior?

The PR corrects the code example to show the proper way to initialize a DispatcherQueueTimer.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@XAML-Knight XAML-Knight added bug 🐛 An unexpected issue that highlights incorrect behavior documentation 📃 labels Sep 22, 2021
@ghost
Copy link

ghost commented Sep 22, 2021

Thanks XAML-Knight for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@michael-hawker michael-hawker merged commit da3c229 into CommunityToolkit:main Sep 22, 2021
@michael-hawker michael-hawker added this to the 7.1 milestone Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior documentation 📃
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants