Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update winui ref to 2.6.2 #4182

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Update winui ref to 2.6.2 #4182

merged 1 commit into from
Aug 25, 2021

Conversation

Rosuavio
Copy link
Contributor

@Rosuavio Rosuavio commented Aug 17, 2021

Fixes

Updated to winui 2.6.2.

PR Type

What kind of change does this PR introduce?
Updated to winui 2.6.2, this fixes several issues.

  1. ListvewExtensionsPage Command prop not found #4039 seems to be fixed as the ListViewExtention sample opens fine in the sample build with (Debug|x64).
  2. Menu sample sometimes "Render" call fails. #3738 seems fixed as also under (Debug|x64) the menu sample opens instantly and constantly every time.
  3. This fixes the drawing toggle button in the infinite canvas now showing its enabled state (More info in Update all relevant WinUI 2.5 revs to 2.6 #4092).
  • Bugfix

What is the current behavior?

All libraries and the Sample App are built with a dependency on winui 2.6.1, which causes some issues in the sample app in certain non-critical conditions ( built in Debug mode ), and its causes some more impactful issues for the libraries we ship ( in particular the issue with the infinite canvas, listed in #4092 )

What is the new behavior?

All libraries and the Sample App are built with a dependency on winui 2.6.2, which fixes some issues in the sample app in certain non-critical conditions ( built in Debug mode ), and its fixes some more impactful issues for the libraries we ship ( in particular the issue with the infinite canvas )

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Aug 17, 2021

Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@michael-hawker
Copy link
Member

Huh, that's weird - it failed to build the Unit Tests project (but from the generated file):

 "D:\a\1\s\Windows Community Toolkit.sln" (Build target) (1) ->
       "D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj" (default target) (2) ->
       (CoreCompile target) -> 
         D:\a\1\s\UnitTests\UnitTests.UWP\obj\x86\Release\XamlTypeInfo.g.cs(290,36): error CS8305: 'Microsoft.UI.Xaml.Controls.StylesVersion' is for evaluation purposes only and is subject to change or removal in future updates. [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]
         D:\a\1\s\UnitTests\UnitTests.UWP\obj\x86\Release\XamlTypeInfo.g.cs(446,49): error CS8305: 'Microsoft.UI.Xaml.Controls.StylesVersion' is for evaluation purposes only and is subject to change or removal in future updates. [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]
         D:\a\1\s\UnitTests\UnitTests.UWP\obj\x86\Release\XamlTypeInfo.g.cs(447,54): error CS8305: 'Microsoft.UI.Xaml.Controls.StylesVersion' is for evaluation purposes only and is subject to change or removal in future updates. [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]
         D:\a\1\s\UnitTests\UnitTests.UWP\obj\x86\Release\XamlTypeInfo.g.cs(870,20): error CS8305: 'Microsoft.UI.Xaml.Controls.XamlControlsResources.Version' is for evaluation purposes only and is subject to change or removal in future updates. [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]
         D:\a\1\s\UnitTests\UnitTests.UWP\obj\x86\Release\XamlTypeInfo.g.cs(870,20): error CS8305: 'Microsoft.UI.Xaml.Controls.XamlControlsResources.Version.get' is for evaluation purposes only and is subject to change or removal in future updates. [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]
         D:\a\1\s\UnitTests\UnitTests.UWP\obj\x86\Release\XamlTypeInfo.g.cs(875,13): error CS8305: 'Microsoft.UI.Xaml.Controls.XamlControlsResources.Version' is for evaluation purposes only and is subject to change or removal in future updates. [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]
         D:\a\1\s\UnitTests\UnitTests.UWP\obj\x86\Release\XamlTypeInfo.g.cs(875,13): error CS8305: 'Microsoft.UI.Xaml.Controls.XamlControlsResources.Version.set' is for evaluation purposes only and is subject to change or removal in future updates. [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]
         D:\a\1\s\UnitTests\UnitTests.UWP\obj\x86\Release\XamlTypeInfo.g.cs(875,29): error CS8305: 'Microsoft.UI.Xaml.Controls.StylesVersion' is for evaluation purposes only and is subject to change or removal in future updates. [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]
         D:\a\1\s\UnitTests\UnitTests.UWP\obj\x86\Release\XamlTypeInfo.g.cs(880,20): error CS8305: 'Microsoft.UI.Xaml.Controls.XamlControlsResources.UseCompactResources' is for evaluation purposes only and is subject to change or removal in future updates. [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]
         D:\a\1\s\UnitTests\UnitTests.UWP\obj\x86\Release\XamlTypeInfo.g.cs(880,20): error CS8305: 'Microsoft.UI.Xaml.Controls.XamlControlsResources.UseCompactResources.get' is for evaluation purposes only and is subject to change or removal in future updates. [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]
         D:\a\1\s\UnitTests\UnitTests.UWP\obj\x86\Release\XamlTypeInfo.g.cs(885,13): error CS8305: 'Microsoft.UI.Xaml.Controls.XamlControlsResources.UseCompactResources' is for evaluation purposes only and is subject to change or removal in future updates. [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]
         D:\a\1\s\UnitTests\UnitTests.UWP\obj\x86\Release\XamlTypeInfo.g.cs(885,13): error CS8305: 'Microsoft.UI.Xaml.Controls.XamlControlsResources.UseCompactResources.set' is for evaluation purposes only and is subject to change or removal in future updates. [D:\a\1\s\UnitTests\UnitTests.UWP\UnitTests.UWP.csproj]

I don't think we're using any of these anywhere (as we've only used the stable WinUI 2.x releases up to this point). We can probably add CS8305 to the ignore list of the UnitTest project?

FYI @ranjeshj

@michael-hawker
Copy link
Member

@RosarioPulella welcome back! FYI, they shipped a 2.6.2 stable, so we can switch to that now, re-test and then should be able to merge this?

@Rosuavio Rosuavio marked this pull request as ready for review August 23, 2021 18:19
@XAML-Knight
Copy link
Contributor

XAML-Knight commented Aug 23, 2021

I am able to ink on the Infinite Canvas (via mouse), but only after doing what isn't all that immediately obvious, which is to click & enable the Touch Inking button:

image

@Rosuavio
Copy link
Contributor Author

I am able to ink on the Infinite Canvas (via mouse), but only after doing what isn't all that immediately obvious, which is to click & enable the Touch Inking button:

This is the existing behavior of the infinite canvas, and I believe it was intentional. Not sure who or when the control was added, but if you want to open up a discussion on this behavior I would recommend opening the separate issue or github discussion. The scope of this PR is just updating to winui 2.6.2 and the relevant issues the update fixes.

@michael-hawker michael-hawker added the next preview ✈️ Label for marking what we want to include in the next preview release for developers to try. label Aug 24, 2021
@michael-hawker michael-hawker merged commit 83a5bce into CommunityToolkit:main Aug 25, 2021
@michael-hawker michael-hawker added this to the 7.1 milestone Aug 25, 2021
@Rosuavio Rosuavio deleted the winui-2.6.2-preview branch August 25, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next preview ✈️ Label for marking what we want to include in the next preview release for developers to try.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants