Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled deterministic builds. #3309

Merged
merged 3 commits into from
May 28, 2020
Merged

Enabled deterministic builds. #3309

merged 3 commits into from
May 28, 2020

Conversation

azchohfi
Copy link
Contributor

Fixes #3308

PR Type

What kind of change does this PR introduce?

  • Build or CI related changes

What is the current behavior?

Builds are not deterministic (https://github.com/clairernovotny/DeterministicBuilds)

What is the new behavior?

Builds are deterministic.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@ghost
Copy link

ghost commented May 28, 2020

Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned Kyaa-dost May 28, 2020
@ghost ghost added the feature request 📬 A request for new changes to improve functionality label May 28, 2020
@michael-hawker
Copy link
Member

@azchohfi looks like this fails the CI.

@azchohfi azchohfi marked this pull request as ready for review May 28, 2020 07:42
@michael-hawker michael-hawker added this to the 6.1 milestone May 28, 2020
@michael-hawker
Copy link
Member

@Kyaa-dost want to just double-check you can build and run the Sample App on your machine with this change and we'll merge after?

@azchohfi
Copy link
Contributor Author

It is still missing some green checks for the Controls, the DataGrid and the GazeInput projects. The Controls and DataGrid are known, since they are missing the pdbs for the design projects, but the GazeInput is warning about a missing pdb for a winmd. @clairernovotny do you know if this is a false positive on NuGet Package Explorer, maybe?

@clairernovotny
Copy link
Member

Not sure how it's a false warning if the pdb isn't there? :)

image

It's possible that there are winmd issues and I'm happy to debug/fix those if they appear.

@azchohfi
Copy link
Contributor Author

I didn't see the missing pdb for the winmd... I thought it was a false positive since we do have the pdbs for the runtimes:
image
This PDB is >10MB. Also... we are using the Win32 build of the winmd (it is generated for each arch), and that pdb is there, its just not on the same folder. What are we doing wrong here? https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/26d00f24556dbd274981901b2961f08dc7b1a20e/build/Microsoft.Toolkit.Uwp.Input.GazeInteraction.nuspec#L21
I'm not sure what the right approach is here.

@clairernovotny
Copy link
Member

Why is that generating a full pdb? If it's portable it should be a lot smaller...

@clairernovotny
Copy link
Member

why is it being built per architecture?

@clairernovotny
Copy link
Member

Ah, right, it's C++ :)

I would exclude the full PDB, there's nothing you can do there.

Copy link
Contributor

@Kyaa-dost Kyaa-dost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @azchohfi and performing as expected 🚀🚀

CC: @michael-hawker

@azchohfi azchohfi merged commit 44b23de into master May 28, 2020
@delete-merged-branch delete-merged-branch bot deleted the deterministicBuilds branch May 28, 2020 19:53
@Kyaa-dost Kyaa-dost added feature 💡 build 🔥 improvements ✨ and removed feature request 📬 A request for new changes to improve functionality feature 💡 labels Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Deterministic builds
4 participants