Fix Mouse Cursor Extensions not changing cursor back #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pointer Exit is sometimes called originating from the element itself, which in turn causes it to set the pointer to the changed cursor instead of back to something else. This checks that the source is not the item we've attached the property to.
nmetulev
approved these changes
Feb 8, 2019
azchohfi
approved these changes
Feb 8, 2019
|
This PR is linked to unclosed issues. Please check if one of these issues should be closed: #2017 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #2017
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Sometimes when using Mouse Extensions the cursor doesn't change back properly.
What is the new behavior?
Now cursor should be properly restored.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Pointer Exit is sometimes called originating from the element itself, which in turn causes it to set the pointer to the changed cursor instead of back to something else. This checks that the source is not the item we've attached the property to.
Unfortunately, the original issue filed with GridSplitter is entirely different as there's a lot more logic there. We should refactor GridSplitter for 6.0 to use Mouse Extensions instead, I have some of this done already as part of another more general 'ContentSplitter' control I've written.