Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkdownTextBlock throw ArgumentException while rendering link with code text #3123

Closed
Tlaster opened this issue Feb 7, 2020 · 6 comments · Fixed by #3407
Closed

MarkdownTextBlock throw ArgumentException while rendering link with code text #3123

Tlaster opened this issue Feb 7, 2020 · 6 comments · Fixed by #3407
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 markdown 📑 Issues related to Markdown
Milestone

Comments

@Tlaster
Copy link

Tlaster commented Feb 7, 2020

Describe the bug

Try rendering markdown like this

[`code`](https://github.com/)

And the MarkdownTextBlock throw ArgumentException

Steps to Reproduce

Steps to reproduce the behavior:

  1. Open Sample App
  2. Open MarkDownTextBlock sample
  3. Add the following markdown to the textbox at the top:
[`code`](https://github.com/)
  1. Sample App crash

Expected behavior

MarkdownTextBlock render like this:
code

Environment

NuGet Package(s): 
6.0.0
Package Version(s): 
6.0.0

Windows 10 Build Number:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [x] May 2019 Update (18362)
- [ ] Insider Build (build number: )

App min and target version:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [x] October 2018 Update (17763)
- [ ] May 2019 Update (18362)
- [ ] Insider Build (xxxxx)

Device form factor:
- [x] Desktop
- [ ] Xbox
- [ ] Surface Hub
- [ ] IoT

Visual Studio 
- [ ] 2017 (version: )
- [x] 2019 (version: 16.4.4) 
- [ ] 2019 Preview (version: )

@Tlaster Tlaster added the bug 🐛 An unexpected issue that highlights incorrect behavior label Feb 7, 2020
@ghost ghost added the needs triage 🔍 label Feb 7, 2020
@ghost
Copy link

ghost commented Feb 7, 2020

Hello Tlaster, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will investigate the issue and help solve it ASAP. Other community members may also look into the issue and provide feedback 🙌

@Kyaa-dost
Copy link
Contributor

Kyaa-dost commented Feb 7, 2020

@Tlaster I am not able to reproduce. Can you please show a screenshot or a screen record that displays the following [code] (https://github.com/) is crashing the Sample APP?

@Kyaa-dost
Copy link
Contributor

The issue might be related to #3120 except in that scenario [ ] (https://www.google.com/) is crashing the app.

@ghost ghost added the needs attention 👋 label Feb 22, 2020
@ghost
Copy link

ghost commented Feb 22, 2020

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

1 similar comment
@ghost
Copy link

ghost commented Mar 24, 2020

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

@yoshiask
Copy link
Contributor

yoshiask commented May 6, 2020

I just tried this in version 6.0.0 of the Sample App, and it does not crash. However, as long as a code block is contained in a link, the MarkdownTextBlock is not updated.

EDIT: Note that I'm using it from the Store, which may have an effect on whether or not the app actually crashes. Either way, there's still unusual and unexpected behavior here.

michael-hawker added a commit to MicrosoftDocs/WindowsCommunityToolkitDocs that referenced this issue Jun 9, 2020
michael-hawker added a commit to MicrosoftDocs/WindowsCommunityToolkitDocs that referenced this issue Jun 9, 2020
@Kyaa-dost Kyaa-dost modified the milestones: 6.1, 7.0 Jun 22, 2020
Sergio0694 added a commit to Sergio0694/WindowsCommunityToolkit that referenced this issue Aug 3, 2020
@ghost ghost added the In-PR 🚀 label Aug 3, 2020
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Aug 3, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 markdown 📑 Issues related to Markdown
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants