Refactor metrics and sync with current Indy for features. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the metrics subsystem to generalize the interceptor + wrap-with-metrics features away from dropwizard's metrics API. Dropwizard now becomes a provider for the metric implementation, without affecting the way metrics are triggered. Accordingly, the console / graphite reporters are factored out, with the graphite reporter put in a separate module from the dropwizard core. This commit also synchronizes with the current Indy master branch, bringing in cumulative metrics functions (for reporting to logging systems currently) and support for wrapping arbitrary code blocks with metrics (using a lambda). Note that with this commit, the following control levels are available: - global enable/disable of metrics - dropwizard-subsystem enable/disable/selection of metrics (choose which ones to report in DW) - graphite / console reporter enable/disable/selection of metrics - control over whether to report a metric cumulatively, using ThreadContext from weft each of these will get a config section (metrics.global, metrics.dropwizard, metrics.dropwizard.graphite, metrics.dropwizard.console) to allow separate selection of metrics for each. The zabbix and elasticsearch reporters have been removed, since they have never been used, and won't be in the forseeable future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the metrics subsystem to generalize the interceptor + wrap-with-metrics features away from dropwizard's metrics API. Dropwizard now becomes a provider for the metric implementation, wit
This commit also synchronizes with the current Indy master branch, bringing in cumulative metrics functions (for reporting to logging systems currently) and support for wrapping arbitrary code blocks with me
Note that with this commit, the following control levels are available:
each of these will get a config section (metrics.global, metrics.dropwizard, metrics.dropwizard.graphite, metrics.dropwizard.console) to allow separate selection of metrics for each.
The zabbix and elasticsearch reporters have been removed, since they have never been used, and won't be in the forseeable future.