[tunnelbroker] add errorType patterns for alarming on tunnelbroker fo…

…r notifs

Summary:
I'm not 100% if we should be alarming on these given that looking through prior logs, we're spammed with failed FCM notifications. Putting this diff up for feedback

Depends on D13454

Test Plan: Test that alarms are triggerable later in stack

Reviewers: kamil, bartek, varun

Reviewed By: varun

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D13455

services/tunnelbroker/src/notifs/fcm/mod.rs

@@ -1,3 +1,4 @@
+use crate::constants::error_types;
 use crate::constants::PUSH_SERVICE_REQUEST_TIMEOUT;
 use crate::notifs::fcm::config::FCMConfig;
 use crate::notifs::fcm::error::Error::FCMError;
@@ -80,8 +81,11 @@ impl FCMClient {
           .await
           .unwrap_or_else(|error| format!("Error occurred: {}", error));
         error!(
+          errorType = error_types::FCM_ERROR,
           "Failed sending FCM notification to: {}. Status: {}. Body: {}",
-          token, error_status, body
+          token,
+          error_status,
+          body
         );
         let fcm_error = FCMErrorResponse::from_status(error_status, body);
         Err(FCMError(fcm_error))

services/tunnelbroker/src/notifs/wns/mod.rs

@@ -70,6 +70,7 @@ impl WNSClient {
           .await
           .unwrap_or_else(|error| format!("Error occurred: {}", error));
         tracing::error!(
+          errorType = error_types::WNS_ERROR,
           "Failed sending WNS notification to: {}. Status: {}. Body: {}",
           &url,
           error_status,