Skip to content

Commit

Permalink
[terraform] Enable apply immediately parameter for aws rds changes
Browse files Browse the repository at this point in the history
Summary:
Before we do an instance size upgrade, we should enable "apply immediately" as a parameter for our aws rds instance so we can ensure downtime occurs on apply and not later

Depends on D13506

Test Plan: after specifying apply immediately, upgrading instance size through `terraform.tfvars.json` immediately applys as confirmed by aws console

Reviewers: bartek, varun, ashoat

Reviewed By: ashoat

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D13507
  • Loading branch information
wyilio committed Sep 30, 2024
1 parent f1da207 commit ea2feac
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions services/terraform/self-host/aws_db.tf
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ resource "aws_db_instance" "mariadb" {
storage_encrypted = true
publicly_accessible = true
port = local.mariadb_port
apply_immediately = true
skip_final_snapshot = true
}

Expand Down

0 comments on commit ea2feac

Please sign in to comment.