[keyserver][lib] Allow not specifying messageID in message report res…

…ponder

Summary:
We want to allow reporting E2EE messages, but without the contents.

Depends on D13459

Test Plan: Confirm that pressing "Report" on a thick thread message no longer leads to an error, and confirm that the authoritative keyserver admin gets a message that looks like this: {F2805570}

Reviewers: kamil, tomek

Reviewed By: tomek

Differential Revision: https://phab.comm.dev/D13460

keyserver/src/creators/message-report-creator.js

@@ -78,10 +78,13 @@ async function fetchMessageReportData(
   request: MessageReportCreationRequest,
 ): Promise<MessageReportData> {
   const keyserverAdminIDPromise = fetchKeyserverAdminID();
-  const reportedMessagePromise = fetchMessageInfoByID(
-    viewer,
-    request.messageID,
-  );
+  const reportedMessagePromise = (async () => {
+    const { messageID } = request;
+    if (!messageID) {
+      return null;
+    }
+    return await fetchMessageInfoByID(viewer, messageID);
+  })();
   const viewerUsernamePromise = fetchUsername(viewer.id);
 
   const keyserverAdminID = await keyserverAdminIDPromise;

keyserver/src/responders/message-report-responder.js

@@ -1,6 +1,6 @@
 // @flow
 
-import type { TInterface } from 'tcomb';
+import t, { type TInterface } from 'tcomb';
 
 import {
   type MessageReportCreationRequest,
@@ -13,7 +13,7 @@ import type { Viewer } from '../session/viewer.js';
 
 export const messageReportCreationRequestInputValidator: TInterface<MessageReportCreationRequest> =
   tShape<MessageReportCreationRequest>({
-    messageID: tID,
+    messageID: t.maybe(tID),
   });
 
 async function messageReportCreationResponder(

lib/actions/message-report-actions.js

@@ -1,12 +1,13 @@
 // @flow
 
-import { extractKeyserverIDFromID } from '../keyserver-conn/keyserver-call-utils.js';
+import { extractKeyserverIDFromIDOptional } from '../keyserver-conn/keyserver-call-utils.js';
 import { useKeyserverCall } from '../keyserver-conn/keyserver-call.js';
 import type { CallKeyserverEndpoint } from '../keyserver-conn/keyserver-conn-types.js';
 import type {
   MessageReportCreationRequest,
   MessageReportCreationResult,
 } from '../types/message-report-types.js';
+import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js';
 
 const sendMessageReportActionTypes = Object.freeze({
   started: 'SEND_MESSAGE_REPORT_STARTED',
@@ -20,8 +21,13 @@ const sendMessageReport =
     input: MessageReportCreationRequest,
   ) => Promise<MessageReportCreationResult>) =>
   async input => {
-    const keyserverID = extractKeyserverIDFromID(input.messageID);
-    const requests = { [keyserverID]: input };
+    const messageKeyserverID = input.messageID
+      ? extractKeyserverIDFromIDOptional(input.messageID)
+      : null;
+    const keyserverID: string =
+      messageKeyserverID ?? authoritativeKeyserverID();
+    const messageID = messageKeyserverID ? input.messageID : null;
+    const requests = { [keyserverID]: { messageID } };
 
     const responses = await callKeyserverEndpoint(
       'create_message_report',

lib/types/message-report-types.js

@@ -3,7 +3,7 @@
 import type { RawMessageInfo } from './message-types.js';
 
 export type MessageReportCreationRequest = {
-  +messageID: string,
+  +messageID: ?string,
 };
 
 export type MessageReportCreationResult = {