Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: support pixi and venv in .envrc #367

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Aug 9, 2024

Follow-up to #354, now with support for venv, uv venv, and pixi environments.

@redeboer redeboer added the ✨ Feature New feature added to the package label Aug 9, 2024
@redeboer redeboer added this to the 0.3.19 milestone Aug 9, 2024
@redeboer redeboer self-assigned this Aug 9, 2024
Does not work without an internet connectsion
@redeboer redeboer enabled auto-merge (squash) August 9, 2024 20:38
@redeboer redeboer merged commit 84e5d7f into ComPWA:main Aug 9, 2024
18 checks passed
@redeboer redeboer deleted the extend-direnv branch August 9, 2024 20:38
@shenvitor
Copy link
Member

Impressive update!

@redeboer
Copy link
Member Author

redeboer commented Aug 9, 2024

Fancy and handy, but it is not necessarily good practice. A repo with it's own .envrc makes it almost impossible to work with your own custom .envrc. It can also pose a security risk if you just run direnv allow on some cloned repo that provides its own .envrc, see e.g. this discussion.

Anyway, for now I see it as a bridge towards #333, especially with uv and/or pixi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature New feature added to the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants