DX: enforce imports to top by default
#270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redeboer
requested changes
Apr 25, 2024
redeboer
changed the title
imports to top by default
redeboer
changed the title
imports to top by defaultimports to top by default
shenvitor
force-pushed
the
E402import-to-top
branch
from
49a85a3
to
6340b6d
Compare
|
Let's make this a draft for now |
|
This is done already seems like? |
|
This could be fixed with ComPWA/policy#392, but it's not the most ideal because you have to list all excepted notebooks with |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
redeboer
approved these changes
Sep 26, 2024
|
CI should be fixed again once #294 is through. @shenvitor could you review that PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for ComPWA/report#12