Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve usage of symplot.SliderKwargs #109

Merged
merged 3 commits into from
Aug 3, 2021
Merged

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Aug 3, 2021

Some minor changes that improve usage of symplot, but don't affect interface. Required for ComPWA/compwa.github.io#37.

  • Set step size (not number of steps) if n_steps is float in set_ranges
  • Unhide _sliders and _arg_to_symbol attributes of SliderKwargs

Keep definitions close to where they are used
@redeboer redeboer added this to the 0.10.4 milestone Aug 3, 2021
@redeboer redeboer self-assigned this Aug 3, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@redeboer redeboer enabled auto-merge (squash) August 3, 2021 12:52
@redeboer redeboer merged commit 0124b44 into main Aug 3, 2021
@redeboer redeboer deleted the improve-symplot branch August 3, 2021 12:55
@redeboer redeboer modified the milestones: 0.10.5, 0.10.4 Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant