Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ignore panel css to increase main content width #104

Merged
merged 7 commits into from
Jul 28, 2021

Conversation

ianhi
Copy link
Contributor

@ianhi ianhi commented Jul 27, 2021

@redeboer
Copy link
Member

redeboer commented Jul 27, 2021

Hey, cool, thanks for looking into this :)
Actually I played around a bit with this after I saw your commit mpl-extensions/mpl-interactions@2122a69. You spotted that well, I wasn't aware of that config from sphinx-panels!

I still have to think about this a bit though. I noticed that the pages of EPB projects all have this wider view, but I personally prefer to have texts less wide. It's for the same reason that newspapers (and many journals) write in columns: it's more convenient for reading. And if you prefer a wider view, you can collapse the left sidebar. (At the same time though, you could say readers should just make their window smaller if they prefer...)

@redeboer redeboer changed the title doc: ignore panel css to increase main content width docs: ignore panel css to increase main content width Jul 27, 2021
@redeboer redeboer added the 📝 Docs Improvements or additions to documentation label Jul 27, 2021
@redeboer redeboer added this to the 0.10.4 milestone Jul 28, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@redeboer
Copy link
Member

I've this discussed your suggestion a bit in my group. They are in favour of a wider page width, so I'll merge this one. Thanks again for noting this!

To summarize:

  • EPB uses this width as well.
  • If you want a smaller page width, just make narrow your window.
  • Many equations in AmpForm are quite wide, so a wider page width is more suitable.

@redeboer redeboer self-requested a review July 28, 2021 14:15
@redeboer redeboer enabled auto-merge (squash) July 28, 2021 14:16
@redeboer redeboer merged commit 6dbdd07 into ComPWA:main Jul 28, 2021
@redeboer redeboer modified the milestones: 0.10.5, 0.10.4 Aug 3, 2021
redeboer added a commit to ComPWA/compwa.github.io that referenced this pull request Aug 3, 2021
redeboer added a commit to ComPWA/PWA-pages that referenced this pull request Aug 28, 2021
redeboer added a commit to ComPWA/PWA-pages that referenced this pull request Aug 28, 2021
redeboer added a commit to ComPWA/qrules that referenced this pull request Sep 13, 2021
redeboer added a commit to ComPWA/tensorwaves that referenced this pull request Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants