Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap-switch to v3.4.0. #2710

Closed
wants to merge 1 commit into from
Closed

Update bootstrap-switch to v3.4.0. #2710

wants to merge 1 commit into from

Conversation

XhmikosR
Copy link
Contributor

The previous version didn't support Bootstrap 4.x.

@XhmikosR
Copy link
Contributor Author

Now I see 533a765#diff-b9cfc7f2cdf78a7f4b91a753d10865a2 but it doesn't mention why it was reverted?

@REJack
Copy link
Collaborator

REJack commented May 30, 2020

One of our users found a massive bug in v3.4.0 also it's only published on npm but there is no github tag for v3.4.0, reference issue is #2605.

@XhmikosR
Copy link
Contributor Author

I agree about it not being published on GitHub, but that could probably be something they missed. That being said, 3.3.4 isn't compatible with Bootstrap 4.x.

Has the issue been reported upstream?

@XhmikosR
Copy link
Contributor Author

It seems that project is poorly maintained. I'll close this PR, but better look for an alternative if the issues aren't fixed soon :/

Bttstrp/bootstrap-switch#717

@XhmikosR XhmikosR closed this May 30, 2020
@REJack
Copy link
Collaborator

REJack commented May 30, 2020

Yeah I know it's not maintained right now from the author, also since I've decided to drop jquery with v4 (like BS5 will do), I'll need to search good alternatives for the most 3rd-plugins.

@XhmikosR XhmikosR deleted the update-bootstrap-switch branch June 1, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants