Skip to content

Custom Background Enhancements Part 1 (#560) #969

Custom Background Enhancements Part 1 (#560)

Custom Background Enhancements Part 1 (#560) #969

Triggered via push August 25, 2024 16:27
Status Success
Total duration 2m 38s
Artifacts 1

build.yml

on: push
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

11 warnings
build (Release, x64, net8.0-windows10.0.22621.0)
embed field value must be shorter than 1024, got 1758 [`1d1685a`](https://github.com/CollapseLauncher/Collapse/commit/1d1685a6d1a4db7d552dac1eb4d3da5ba6baf004) Custom Background Enhancements Part 1 (#560) # Main Goal The initial goal of this PR is to bring the background changing functionality into the Quick Settings menu for easier access. This works __*exactly*__ in the same way as the one in Game Settings does. The end-goal of this change is to eventually remove the button from the Application Settings page and have it reside exclusively in Quick Settings, as background assets will be managed on a per-game and per-region basis (hence "Part 1"). PS. This feature does not require global App custom background to be enabled. Simply go to the "Additional Button" in home page (bottom right) and change the toggle and background there. - **[New]**: Add background change to quick settings menu ## PR Status : - Overall Status : In Progress - Commits : In Progress - Synced to base (Collapse:main) : Yes - Build status : OK ✅ - Crashing : No ## TODO - [x] Fix issue where `bool` value is not applied to `ToggleSwitch` for both Custom Args & Region Background toggles - [x] Fix i18n for `Button` and `StackPanel` Text properties - [x] Validate if bool applies to Application Settings page if it is changed in Quick Settings - [x] Fix issue where applying a video background to a different game/region that has an image applied will hard crash the application OR no longer apply media to the container. > This was apparently an old bug since video background were ever implemented, but we forgor so we spent at least 4 man hours trying to find the issue and it was an Opacity that was set to 0 and never gets set back to 1. welp. > - dont ask about it (@neon-nyan)
build (Release, x64, net8.0-windows10.0.22621.0): Hi3Helper.Http/Class/Session/SessionManager.cs#L86
'Http.GetHashNumber(long, long, long, long)' is obsolete: 'The file order should've now been in-order rather than randomized with this GetHashNumber method. Use .00x extenstion instead!'
build (Release, x64, net8.0-windows10.0.22621.0): Hi3Helper.Http/Class/Session/SessionManager.cs#L195
'Http.GetHashNumber(long, long, long, long)' is obsolete: 'The file order should've now been in-order rather than randomized with this GetHashNumber method. Use .00x extenstion instead!'
build (Release, x64, net8.0-windows10.0.22621.0): Hi3Helper.Http/Class/Session/SessionManager.cs#L230
'Http.GetHashNumber(long, long, long, long)' is obsolete: 'The file order should've now been in-order rather than randomized with this GetHashNumber method. Use .00x extenstion instead!'
build (Release, x64, net8.0-windows10.0.22621.0): Hi3Helper.Http/Class/Session/SessionMerge.cs#L29
'Http.GetHashNumber(long, long, long, long)' is obsolete: 'The file order should've now been in-order rather than randomized with this GetHashNumber method. Use .00x extenstion instead!'
build (Release, x64, net8.0-windows10.0.22621.0): CollapseLauncher/Classes/InstallManagement/BaseClass/GameInstallPackage.cs#L107
'Http.GetHashNumber(long, long, long, long)' is obsolete: 'The file order should've now been in-order rather than randomized with this GetHashNumber method. Use .00x extenstion instead!'
build (Release, x64, net8.0-windows10.0.22621.0): CollapseLauncher/Classes/InstallManagement/BaseClass/GameInstallPackage.cs#L164
'Http.GetHashNumber(long, long, long, long)' is obsolete: 'The file order should've now been in-order rather than randomized with this GetHashNumber method. Use .00x extenstion instead!'
build (Release, x64, net8.0-windows10.0.22621.0): CollapseLauncher/Classes/InstallManagement/BaseClass/GameInstallPackage.cs#L207
'Http.GetHashNumber(long, long, long, long)' is obsolete: 'The file order should've now been in-order rather than randomized with this GetHashNumber method. Use .00x extenstion instead!'
build (Release, x64, net8.0-windows10.0.22621.0): CollapseLauncher/Classes/InstallManagement/BaseClass/GameInstallPackage.cs#L244
'Http.GetHashNumber(long, long, long, long)' is obsolete: 'The file order should've now been in-order rather than randomized with this GetHashNumber method. Use .00x extenstion instead!'
build (Release, x64, net8.0-windows10.0.22621.0): CollapseLauncher/Classes/InstallManagement/BaseClass/GameInstallPackage.cs#L107
'Http.GetHashNumber(long, long, long, long)' is obsolete: 'The file order should've now been in-order rather than randomized with this GetHashNumber method. Use .00x extenstion instead!'
build (Release, x64, net8.0-windows10.0.22621.0): CollapseLauncher/Classes/InstallManagement/BaseClass/GameInstallPackage.cs#L164
'Http.GetHashNumber(long, long, long, long)' is obsolete: 'The file order should've now been in-order rather than randomized with this GetHashNumber method. Use .00x extenstion instead!'

Artifacts

Produced during runtime
Name Size
collapse_x64-Release_net8.0-windows10.0.22621.0_1d1685a6d1a4db7d552dac1eb4d3da5ba6baf004
48.2 MB