Return error when record is too short #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code here works barring the comments in the PR that I'm not sure about. Feel free to close this PR and adapt the code in a new one (Or just push to this one) |
|
Closing since it looks like #2 was fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
I'm not entirely sure this is the best way to fix this, but the check needed to have been done up in NtfsFile because everything below it (in the process of getting the signature) is infalliable.
I also don't like the
vec![0; record_size]there, looks like a malformed file system can cause an OOM. Granted, it's a u32 so that might still be fine on some platforms, but definitely not on embedded. Best thing to do there would be to validate that the stream length is actually long enough to fit the given record size