AlphaTexImporter corrections and simplifications #852
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed some things I found in AlphaTexImporter.
List of changes
MalFormed AlphaTex: @22: Error on block keysignature, expected a String found a MetaCommand: 'null'
MalFormed AlphaTex: @22: Error on block keysignature, expected a String found a MetaCommand: 'ro'
parseKeySignature
reference theKeySignature
enum instead of literals.KeySignature.CSharp
.rc
tag. Typing a large number on this tag in the playground made the browser freeze and run out of memory due to the size of the midi generated. I hope it was OK to include this, I understand if you don't want to introduce hidden limits though. Maybe this could be discussed in a different issue.Checklist
Further details