Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to respect current and known next beat on cursor changes. #645

Merged
merged 3 commits into from
Aug 14, 2021
Merged

Try to respect current and known next beat on cursor changes. #645

merged 3 commits into from
Aug 14, 2021

Conversation

Danielku15
Copy link
Member

Issues

Fixes #558

Proposed changes

We remember the tick lookup and consider this info on cursor changes to efficiently select the next beat.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Aug 14, 2021
@Danielku15 Danielku15 merged commit 433cbf3 into develop Aug 14, 2021
@Danielku15 Danielku15 deleted the feature/optimized-beat-lookup branch August 14, 2021 11:52
@Danielku15 Danielku15 mentioned this pull request Aug 16, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Danielku15 Danielku15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Danielku15