-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import volume and balance from MusicXML #451 #454
Import volume and balance from MusicXML #451 #454
Conversation
Clamping the balance from -90 to 90 sounds good according to the MusicXML standard. 0 in alphaTab is -90 MusicXML and 16 is 90. There is no balance at this point which puts the audio "behind" the listener. To create a test it might be easiest to create a MusicXML file via MuseScore and then use it in the tests as usual: load the file with the importer, check the values from the imported data model. You could add it to the |
ce714e2
to
3538829
Compare
Like this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: The workflow on pull requests should be something like:
- As long as you're working on it, keep it as draft pull request
- When you have the feeling it is ready you can request a review from me and then I will have a look and add comments. Maybe I approve+merge it, or I request changes.
This way I know what state the PRs are in and if I should have a look already.
You can read more about this workflows and ideas in the GitHub Docs: https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/proposing-changes-to-your-work-with-pull-requests
@@ -0,0 +1,518 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the new "custom" testfiles somewhere outside the "musicxml-testsuite". This folder is a 3rd-party MusicXML testsuite. It is not really maintained by alphaTabThis and the whole folder might be overwritten on updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, didn't know that.
I shall move it later today, do you have any preference for the folder name?
@@ -0,0 +1,518 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with this file, please move it.
To avoid too much noise, you could just add 1 file with multiple tracks where each track has multiple volumes and balances. Then use it in both tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.
Thanks for the info! 😃 |
@jordanske Any plans to finish this PR? There was no update since quite a while so I thought of reaching out to you. |
@Danielku15 My apologies, I've been busy and when I pushed the changes I totally forgot to mention it here. |
Pull request for #451.
I am not sure how I should create a test for MusicXML.
Also I clamped the balance to 0 and 16, because MusicXML allows values lower than -90 and higher than 90.
Or should -135 translate to balance of 4? To keep the left/right panning independently if its before or behind you.