Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we do not signal the UI facade for empty partials #1091

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

Danielku15
Copy link
Member

Issues

Fixes #1090

Proposed changes

ICanvas used to provide some results when render finished but not it doesn't. Due to that the onRenderFinished signals an empty render result to the UI facade to be displayed. The problem is that the new placeholder system does not clear placeholders to get a smoother UI: It is better to keep an old render result before the new one becomes available.

The problem is if the placeholder content has a 0 width and height. We would need to clean the placeholder from its old content because it will never become visible. To avoid implementing this code in every UI facade we simply not signal empty results to the UI facade anymore which will ensure placeholders are only filled with proper content or are removed.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Jan 7, 2023
@Danielku15 Danielku15 merged commit 58ec753 into develop Jan 7, 2023
@Danielku15 Danielku15 deleted the feature/fix-placeholder-clearing branch January 7, 2023 23:47
@goodgame365
Copy link

Thank you very much. The problem has been solved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some partials displayed multiple times on horizontal layout
2 participants