-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NW6 | Fikret Ellek| Module Servers | Stretch challenges | Week 2 #181
base: main
Are you sure you want to change the base?
Conversation
react app ---> https://fe-chat-react-app.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I loved your design and solution! Great job @fikretellek!
I've added some improvements that you might consider.
chat-react-app/src/App.jsx
Outdated
useEffect(() => { | ||
getMessages(); | ||
const interval = setInterval(() => getMessages(), 10000); | ||
return () => clearInterval(interval); | ||
}, []); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Efficiently using the useEffect
and clearInterval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am planning to use websocket to achieve real time communication. I'll try to implement it today. Can we have a meeting about websockets if you have time? I quite didn't understand it 😆
}) | ||
.then((response) => response.json()) | ||
.then((data) => setMessages(data.slice().reverse())); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two suggestions for improvement:
First : consider using state
to store the values of the name and message inputs.
Second : extract the fetch
functionality into its own function to improve code organisation and maintain single responsibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't understand the second suggestion. could you please make it more clear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we can create a single reusable fetch
function to handle the fetching logic, like:
function fetchMessages(url, options) {
return fetch(url, options)
.then((response) => response.json())
.then((data) => data.slice().reverse());
}
then you can use it for both getMessages
and setMessages
:
function getMessages() {
fetchMessages("https://module-servers.onrender.com/messages")
.then((data) => setMessages(data));
}
//...
const requestOptions = {
method: "POST",
headers: {
"Content-Type": "application/json",
},
body: JSON.stringify(newMessage),
};
fetchMessages("https://module-servers.onrender.com/messages", requestOptions)
.then((data) => setMessages(data));
There are different ways to do that, you can update it according to your taste ;)
chat-react-app/src/App.jsx
Outdated
</div> | ||
<div id="messages"> | ||
{messages.map((message, index) => { | ||
const currentUser = document.getElementById("name").value; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same one for this part too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 👍
…n for generating messages implemented
Quality Gate passedIssues Measures |
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.