Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw an error if no visit id is provided to the api/sep endpoint #473

Closed
MikeyManoguerra opened this issue Jan 4, 2021 · 0 comments · Fixed by #502
Closed

throw an error if no visit id is provided to the api/sep endpoint #473

MikeyManoguerra opened this issue Jan 4, 2021 · 0 comments · Fixed by #502
Assignees
@alex-cots

Comments

@MikeyManoguerra
Copy link
Collaborator

lets discuss this before anyone takes it; but there is no situation that the app will need to query all the sep data from the browser. any requests like that should be done on the database directly for reporting services. we should block GET all requests and throw an error, i think
@alex-cots alex-cots self-assigned this Jan 12, 2021
@alex-cots alex-cots linked a pull request Feb 2, 2021 that will close this issue
Visit ID required for sep data 473 #502
Merged
alex-cots added a commit that referenced this issue Feb 17, 2021
@alex-cots
Merge pull request #502 from CodeForPhilly/visit-ID-required-for-sep-…
ece579f 
…data-473

Visit ID required for sep data closes #473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-cots alex-cots

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Visit ID required for sep data 473 CodeForPhilly/prevention-point
2 participants
@MikeyManoguerra @alex-cots