Single account multiple workers #441

bitphage · 2019-02-03T09:46:33Z

Handle multiple workers on same account with Staggered Orders. The feature was funded by Cryptobridge.

joelvai · 2019-02-22T11:43:20Z

To test this properly on GUI as well, you need to remove validation from worker_controller.py which doesn't allow creation of another worker with same account.

Add method for caclulating operational percent Method for caclulating operational percent of asset balance available to the worker when trading same assets on different markets on single account. Add configuration settings for operational balances.

Small refactor to get unified names for properties and methods and to be able use methods instead of properties when `refresh=False` kwarg is needed.

This commit brings support for handling multiple workers on single account with assets intersections into Staggered Orders strategy. See Codaone#434 for discussion.

thehapax · 2019-02-23T23:38:17Z

@PermieBTS requesting additional end-users to test single-account-multiple workers to ensure no-err on funds.

PermieBTS · 2019-02-24T14:42:57Z

I'm looking into ways that our DEXBot community users can help us test.
The problem users give is that they would have to stop their main-workers which they want to run 24/7... in order to test a new feature/version.

So easy ways to run multiple DEXBot instances are needed.

On Linux, if one creates two users, then you can run DEXBot silently in the back ground and the other can run DEXBot too.

Create a new user
Install desired DEXBot version on that user
Log in to DEXBot, configure settings, and run once.
After this you can start and run this DEXBot worker in a terminal

su otheruser changes to other user
screen dexbot-cli run screen lets you detach change user without stopping the bot
ctrl+a and ctrl+d changes screen to control mode
ctrl+d is exit

To reattach and control the other bot again:
su otheruser
screen -r

====================
The DEXBot docker image can also be used to run two simultaneous versions of DEXBot

bitphage · 2019-02-24T19:44:45Z

You may ask cryptobridge team as this feature was implemented by their request and they are active users of it.

When using single account for multiple workers, add/remove of a worker must not touch other workers orders.

bitphage · 2019-03-01T10:08:56Z

joelva2:43 PM
@vvk the multiple workers on one account breaks when closing the second one,

Traceback (most recent call last):
  File "/home/joel/projects/DEXBot/dexbot/views/errors.py", line 95, in func_wrapper
    return func(*args, **kwargs)
  File "/home/joel/projects/DEXBot/dexbot/views/worker_item.py", line 87, in pause_worker
    self.main_ctrl.pause_worker(self.worker_name)
  File "/home/joel/projects/DEXBot/dexbot/controllers/main_controller.py", line 58, in pause_worker
    self.worker_manager.stop(worker_name, pause=True)
  File "/home/joel/projects/DEXBot/dexbot/worker.py", line 198, in stop
    self.accounts.remove(account)
KeyError: 'test-account'

dexbot/strategies/base.py

PermieBTS · 2019-03-03T18:22:12Z

Cryptokong is recieving training on how to test this strategy and recruit end-users to test this strategy

bitphage · 2019-03-15T15:08:19Z

@joelvai can you describe in more details of how you got error KeyError: 'test-account'? I'm unable to reproduce it.

joelvai · 2019-03-22T05:51:10Z

@bitfag sorry for delayed answer.

Create two workers that have same account
Remove worker 1
Remove worker 2

PermieBTS · 2019-04-09T09:49:53Z

Merging of this feature is delayed until unit tested

…tiple-workers

@JoelvA

When removing a worker which uses account being in use by another worker too, we must not remove account subscription. This is a fix for the following condition discovered by @JoelvA: 1. Create two workers that have same account 2. Start both workers 3. Remove worker 1 4. Remove worker 2

To be consistent with param names, input field should be named as `param_name_input`.

When creating or editing worker, param values should be saved to / taken from config.

bitphage · 2019-05-05T18:26:33Z

To obtain win executable for testing, go to "continuous-integration/appveyor/pr" Details -> Artifacts -> download DEXBot-gui-win64.zip

…tiple-workers

thehapax requested a review from joelvai February 6, 2019 18:58

bitphage changed the base branch from master to devel February 12, 2019 14:25

bitphage force-pushed the single-account-multiple-workers branch from 56ec150 to d1913cd Compare February 15, 2019 18:06

bitphage added 6 commits February 23, 2019 14:10

Add method for caclulating assets intersections

6d2a54e

Refactor methods for getting own orders

123eaa9

Small refactor to get unified names for properties and methods and to be able use methods instead of properties when `refresh=False` kwarg is needed.

Small update of docstring and comment

c799f0c

Refactor SO to handle single account with multiple workers

422785b

This commit brings support for handling multiple workers on single account with assets intersections into Staggered Orders strategy. See Codaone#434 for discussion.

Allow to use same account in multiple workers

98af834

bitphage force-pushed the single-account-multiple-workers branch from d1913cd to 98af834 Compare February 23, 2019 09:24

thehapax assigned PermieBTS and unassigned PermieBTS Feb 23, 2019

thehapax requested a review from PermieBTS February 23, 2019 23:37

Cancel only own market orders in cancel_all_orders()

64c4be5

When using single account for multiple workers, add/remove of a worker must not touch other workers orders.

joelvai requested changes Mar 1, 2019

View reviewed changes

dexbot/strategies/base.py Outdated Show resolved Hide resolved

Add operational balance settings into GUI

5ce0ddc

staccDOTsol mentioned this pull request Mar 18, 2019

multiple workers| #514

Closed

Carbon-Zero approved these changes Apr 5, 2019

View reviewed changes

Merge branch 'devel' into single-account-multiple-workers

a1c9e49

bitphage added 3 commits May 5, 2019 21:52

Merge remote-tracking branch 'upstream/devel' into single-account-mul…

137ba41

…tiple-workers

Reformat expression

4816602

bitphage dismissed Carbon-Zero’s stale review via b0b39ee May 5, 2019 17:21

bitphage added 4 commits May 5, 2019 22:30

Fix flake8 warning

cd755b9

Fix typo

529899f

Rename input fields for operational_percent_xxx

33d9fcd

To be consistent with param names, input field should be named as `param_name_input`.

Handle operational_percent_xxx when editing worker

1c90b4b

When creating or editing worker, param values should be saved to / taken from config.

bitphage dismissed Carbon-Zero’s stale review via 1c90b4b May 5, 2019 18:17

Remove unused variable

a289747

bitphage dismissed Carbon-Zero’s stale review via a289747 May 5, 2019 18:23

Merge remote-tracking branch 'upstream/devel' into single-account-mul…

f5db4e8

…tiple-workers

bitphage dismissed Carbon-Zero’s stale review via f5db4e8 May 10, 2019 13:49

PermieBTS mentioned this pull request Aug 5, 2019

GUI does not allow creating mutiple workers that use same account #650

Closed

bitphage added 2 commits September 28, 2019 23:21

Merge remote-tracking branch 'upstream/devel' into single-account-mul…

1bb954e

…tiple-workers

Update docstring

3dd056e

bitphage dismissed Carbon-Zero’s stale review via 3dd056e September 29, 2019 15:40

Add SO test for single account multiple workers

92a1f5f

bitphage dismissed Carbon-Zero’s stale review via 92a1f5f September 29, 2019 17:45

joelvai approved these changes Oct 18, 2019

View reviewed changes

joelvai merged commit 92a1f5f into Codaone:devel Oct 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Single account multiple workers #441

Single account multiple workers #441

bitphage commented Feb 3, 2019

joelvai commented Feb 22, 2019

thehapax commented Feb 23, 2019

PermieBTS commented Feb 24, 2019 •

edited

Loading

bitphage commented Feb 24, 2019

bitphage commented Mar 1, 2019

PermieBTS commented Mar 3, 2019

bitphage commented Mar 15, 2019

joelvai commented Mar 22, 2019 •

edited

Loading

PermieBTS commented Apr 9, 2019

bitphage commented May 5, 2019

Single account multiple workers #441

Single account multiple workers #441

Conversation

bitphage commented Feb 3, 2019

joelvai commented Feb 22, 2019

thehapax commented Feb 23, 2019

PermieBTS commented Feb 24, 2019 • edited Loading

bitphage commented Feb 24, 2019

bitphage commented Mar 1, 2019

PermieBTS commented Mar 3, 2019

bitphage commented Mar 15, 2019

joelvai commented Mar 22, 2019 • edited Loading

PermieBTS commented Apr 9, 2019

bitphage commented May 5, 2019

PermieBTS commented Feb 24, 2019 •

edited

Loading

joelvai commented Mar 22, 2019 •

edited

Loading