Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade version of python-bitshares to 0.3.x #570

Closed
bitphage opened this issue Apr 24, 2019 · 10 comments
Closed

Upgrade version of python-bitshares to 0.3.x #570

bitphage opened this issue Apr 24, 2019 · 10 comments

Comments

@bitphage
Copy link
Collaborator

Need to perform version upgrade, as it contains bug fixes and some of our new features will depend on this new version.

@bitphage bitphage added [3] Type: Maintenance [4] Priority: Medium [5] Medium Task Indicates size of task. Est. between two and five hours labels Apr 24, 2019
@joelvai
Copy link
Collaborator

joelvai commented Apr 24, 2019

I agree. I suppose this could be next on the list after the base refactor is done and before actually new features are implemented. Its not the biggest job, but requires mostly testing.

@PermieBTS
Copy link
Collaborator

@joelvai I agree

@bitphage
Copy link
Collaborator Author

bitphage commented May 9, 2019

I would like to do this before base refactor, as #551 depends on this.

@PermieBTS
Copy link
Collaborator

Is this 570 necessary for #515 ?

bitphage added a commit to bitphage/DEXBot that referenced this issue May 9, 2019
@bitphage
Copy link
Collaborator Author

bitphage commented May 9, 2019

@PermieBTS yes

@thehapax
Copy link
Collaborator

thehapax commented May 9, 2019

my concern about this upgrade to 0.3.x is that currently i'm refactoring base off of pybitshares below 0.2.x If we don't merge and test at least the current portion now, it means base refactor is further behind. Can we just merge in base refactor now and then make unit tests to fit the new framework instead of redundant work?

@PermieBTS
Copy link
Collaborator

PermieBTS commented May 9, 2019

So if @joelvai merged this issue 570 and the base refactor, unit tests can then be written using @bitfag docker

Therefore skipping out the work to complete redundant unit tests in the old style

If @thehapax pushes their work to codaone/542-base-refactor-notests can it be merged friday 10th of May (Tomorrow)?

@thehapax
Copy link
Collaborator

I changed the branch - new name is 542-base-refactor-merge, and the pull request is: #579

@thehapax
Copy link
Collaborator

@joelvai you can delete codaone/542-base-refactor-notests this is no longer used.

@bitphage
Copy link
Collaborator Author

Versions upgraded.

@PermieBTS PermieBTS added [1] Status: Completed and removed [3] Type: Maintenance [4] Priority: Medium [5] Medium Task Indicates size of task. Est. between two and five hours labels Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants