Prevent floating animation when there is already a default value setted #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Cnilton Hi, can you take a look? |
|
@Hantex9, sorry for taking so long.. but I tested your solution and still isn't right. I will try to fix this. |
|
Can you please try the latest version, 1.4.3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intro
A while ago I used this library in order to have floating label inputs on a personal react-native project and I faced on the following issue #133, later on i fixed it on the project and i'm opening this PR in order to share with you the fix that can be really useful for those people like me that doesn't want to see the label animation fired on inputs with a value already provided before the component render.
Details
When there was a default value setted, the floating animation was fired on the component render even if there was not focused, providing a UI bug as showed in the issue #133.