disable compression for zip #1296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DasBabyPixel
force-pushed
the
fast-compression
branch
2 times, most recently
from
f2a2fa2
to
d2e814f
Compare
DasBabyPixel
force-pushed
the
fast-compression
branch
from
d2e814f
to
7a2d597
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Creating a zip for a directory that should be sent over the network takes very long.
Disabling compression makes quite a noticeable improvement in the time it takes for the file to start being sent over the network. Actually sending the file doesn't even take longer most of the time because large files for minecraft servers (region files, jars) are compressed by default and trying to compress them is pointless
Modification
Disabled compression for creating zip files
Result
Faster creating of zips
Other context
An argument can be made to filter for the file extension before zipping, to only disable compression for already compressed entries like jars and region files