[BugFix] Add termination period for static code upload #4250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a graceful termination period time for static code upload jobs.
The issue is that while the sidecar container polls for the submission file, the submission container exists and initiates a TERM signal to all the other containers (sidecar). What this does is that after 30 seconds kills the running sidecar container and the submission never reaches EvalAI backend.
This is fixed by adding a graceful termination period for the sidecar container which is slightly higher than the sleep interval.
Scenarios
There might be a better way to fix this to need as little time as possible while exiting (maybe a
preStop
hook or something else). This may be investigated later on. We also should look into sidecare containers on EKS: https://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/