Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix message receipt in code-upload worker #4176

Merged

Conversation

gchhablani
Copy link
Collaborator

This PR fixes the position of the message receipt handle in code-upload worker.

@codecov-commenter
Copy link

Codecov Report

Merging #4176 (f9711c2) into master (96968d6) will decrease coverage by 3.63%.
Report is 1054 commits behind head on master.
The diff coverage is 46.30%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4176      +/-   ##
==========================================
- Coverage   72.93%   69.30%   -3.63%     
==========================================
  Files          83       20      -63     
  Lines        5368     3574    -1794     
==========================================
- Hits         3915     2477    -1438     
+ Misses       1453     1097     -356     
Files Changed Coverage Δ
frontend/src/js/controllers/analyticsCtrl.js 80.72% <ø> (ø)
frontend/src/js/controllers/authCtrl.js 53.91% <8.33%> (-12.95%) ⬇️
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) ⬇️
frontend/src/js/controllers/challengeCtrl.js 61.23% <38.53%> (-12.47%) ⬇️
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) ⬇️
frontend/src/js/controllers/profileCtrl.js 66.50% <54.48%> (-26.35%) ⬇️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) ⬇️
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/challengeListCtrl.js 93.93% <98.07%> (-0.75%) ⬇️
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
... and 7 more

... and 63 files with indirect coverage changes

Files Changed Coverage Δ
frontend/src/js/controllers/analyticsCtrl.js 80.72% <ø> (ø)
frontend/src/js/controllers/authCtrl.js 53.91% <8.33%> (-12.95%) ⬇️
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) ⬇️
frontend/src/js/controllers/challengeCtrl.js 61.23% <38.53%> (-12.47%) ⬇️
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) ⬇️
frontend/src/js/controllers/profileCtrl.js 66.50% <54.48%> (-26.35%) ⬇️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) ⬇️
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/challengeListCtrl.js 93.93% <98.07%> (-0.75%) ⬇️
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
... and 7 more

... and 63 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be6474...f9711c2. Read the comment docs.

@gchhablani gchhablani merged commit 1b85045 into Cloud-CV:master Sep 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants