Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix duplicate leaderboard data entry creation on resume #4082

Merged
merged 5 commits into from
Aug 10, 2023

Conversation

Suryansh5545
Copy link
Member

@Suryansh5545 Suryansh5545 commented Aug 3, 2023

fix leaderboard_data being duplicated

Peek.2023-08-04.01-30.mp4

@Suryansh5545 Suryansh5545 changed the title fix leaderboard_data being duplicated [BugFix] Fix leaderboard data being duplicated Aug 3, 2023
@Suryansh5545
Copy link
Member Author

dependent on #4083

@codecov-commenter
Copy link

Codecov Report

Merging #4082 (1fdd75a) into master (96968d6) will decrease coverage by 3.17%.
Report is 990 commits behind head on master.
The diff coverage is 45.94%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #4082      +/-   ##
==========================================
- Coverage   72.93%   69.77%   -3.17%     
==========================================
  Files          83       20      -63     
  Lines        5368     3510    -1858     
==========================================
- Hits         3915     2449    -1466     
+ Misses       1453     1061     -392     
Files Changed Coverage Δ
frontend/src/js/controllers/analyticsCtrl.js 80.72% <ø> (ø)
frontend/src/js/controllers/authCtrl.js 53.91% <8.33%> (-12.95%) ⬇️
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) ⬇️
frontend/src/js/controllers/challengeCtrl.js 62.25% <38.62%> (-11.45%) ⬇️
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) ⬇️
frontend/src/js/controllers/profileCtrl.js 63.77% <48.83%> (-29.09%) ⬇️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) ⬇️
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/challengeListCtrl.js 93.93% <98.07%> (-0.75%) ⬇️
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
... and 7 more

... and 63 files with indirect coverage changes

Files Changed Coverage Δ
frontend/src/js/controllers/analyticsCtrl.js 80.72% <ø> (ø)
frontend/src/js/controllers/authCtrl.js 53.91% <8.33%> (-12.95%) ⬇️
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) ⬇️
frontend/src/js/controllers/challengeCtrl.js 62.25% <38.62%> (-11.45%) ⬇️
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) ⬇️
frontend/src/js/controllers/profileCtrl.js 63.77% <48.83%> (-29.09%) ⬇️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) ⬇️
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/challengeListCtrl.js 93.93% <98.07%> (-0.75%) ⬇️
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
... and 7 more

... and 63 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f4e763...1fdd75a. Read the comment docs.

@gchhablani gchhablani changed the title [BugFix] Fix leaderboard data being duplicated [BugFix] Fix duplicate leaderboard data entry creation on resume Aug 10, 2023
@gchhablani gchhablani merged commit d9dd84c into Cloud-CV:master Aug 10, 2023
1 check failed
gchhablani added a commit that referenced this pull request Sep 19, 2023
gchhablani added a commit that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants