Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppendRow function to BatchColumn #927

Merged
merged 5 commits into from
Mar 8, 2023
Merged

Conversation

pikot
Copy link
Contributor

@pikot pikot commented Mar 6, 2023

Summary

  • add function to batch column. usecase:
    I have data in rows and want to use batch column insert. Logic with creating columns arrays, and iterate this array in Append, looks like overkill. Enough iterate my data rows and call AppendRow without creating column arrays.
  • smallfix for date test

Checklist

  • Unit and integration tests covering the common scenarios were added

@jkaflik jkaflik changed the title add function to batch column, small fix in date test Add AppendRow function to BatchColumn Mar 8, 2023
@jkaflik jkaflik merged commit 45c4fee into ClickHouse:main Mar 8, 2023
@jkaflik
Copy link
Contributor

jkaflik commented Mar 8, 2023

Thanks @pikot . Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants