Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix INSERT statement normalization match backtick table name #1366

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

jkaflik
Copy link
Contributor

@jkaflik jkaflik commented Aug 5, 2024

This solution could be better due to more regex expressions in this logic. Ideally, we can get rid of it in the future. The goal for now is to make it backward-compatible and unified across protocol support.

resolves #1345

@jkaflik jkaflik self-assigned this Aug 5, 2024
@jkaflik jkaflik merged commit 06510b2 into main Aug 5, 2024
7 of 12 checks passed
codeboten pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Aug 7, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/ClickHouse/clickhouse-go/v2](https://togithub.com/ClickHouse/clickhouse-go)
| `v2.26.0` -> `v2.27.1` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.26.0/v2.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.26.0/v2.27.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>ClickHouse/clickhouse-go
(github.com/ClickHouse/clickhouse-go/v2)</summary>

###
[`v2.27.1`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2271-2024-08-05----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.27.0...v2.27.1)

#### What's Changed

##### Fixes 🐛

- Fix INSERT statement normalization match backtick table name by
[@&#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1366

**Full Changelog**:
ClickHouse/clickhouse-go@v2.27.0...v2.27.1

###
[`v2.27.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2270-2024-08-01----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---)

[Compare
Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.26.0...v2.27.0)

#### Breaking change notice

v2.25.0 was released with a breaking change in
[ClickHouse/clickhouse-go#1306.
Please review your implementation.

#### What's Changed

##### Enhancements 🎉

- Unpack value of indirect types in array column to support nested
structures in interfaced slices/arrays by
[@&#8203;jmaicher](https://togithub.com/jmaicher) in
[ClickHouse/clickhouse-go#1350

##### Fixes 🐛

- Common HTTP insert query normalization by
[@&#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1341

##### Other Changes 🛠

- Update examples std json by
[@&#8203;xjeway](https://togithub.com/xjeway) in
[ClickHouse/clickhouse-go#1240
- ClickHouse 24.6 by [@&#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1352
- ClickHouse 24.7 release by
[@&#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1363
- Update CHANGELOG with a breaking change note by
[@&#8203;jkaflik](https://togithub.com/jkaflik) in
[ClickHouse/clickhouse-go#1364

#### New Contributors

- [@&#8203;xjeway](https://togithub.com/xjeway) made their first
contribution in
[ClickHouse/clickhouse-go#1240

**Full Changelog**:
ClickHouse/clickhouse-go@v2.26.0...v2.27.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xOC4xNyIsInVwZGF0ZWRJblZlciI6IjM4LjE4LjE3IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
@jkaflik jkaflik deleted the kk/1345-fix branch August 28, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PrepareBatch for tablename with special characters in name, stop works after upgrade from 2.23.2 to 2.26.0
1 participant