Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add references to CC_DISABLE_BUILD_CACHE_UPLOAD #130

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Add references to CC_DISABLE_BUILD_CACHE_UPLOAD #130

merged 2 commits into from
Jan 15, 2024

Conversation

davlgd
Copy link
Collaborator

@davlgd davlgd commented Jan 5, 2024

Checklist

@davlgd davlgd requested a review from juliamrch January 5, 2024 19:25
@davlgd davlgd self-assigned this Jan 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

Deployment has finished 👁️👄👁️ Your app is available here

juliamrch
juliamrch requested changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@juliamrch juliamrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a link to what the variable does in pages that are unrelated to environment variables, to avoid our readers to get lost. The callout just pops out of no where and can be confusing.

content/doc/administrate/apps-management.md Outdated Show resolved Hide resolved
content/doc/develop/build-hooks.md Outdated Show resolved Hide resolved
@juliamrch juliamrch added documentation Improvements or additions to documentation waiting Waiting from fixes or tests by submitter labels Jan 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2024 •
edited by juliamrch
Loading

🚀 Your app has been updated and is available here

@juliamrch juliamrch merged commit f68f912 into main Jan 15, 2024
3 checks passed
@juliamrch juliamrch deleted the davlgd-disable-build-cache-env branch January 15, 2024 17:14
@github-actions GitHub Actions
Copy link

Your review app has been deleted 👋

juliamrch pushed a commit that referenced this pull request Jan 22, 2024
@davlgd @juliamrch
Add references to CC_DISABLE_BUILD_CACHE_UPLOAD (#130)
8a14aa7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliamrch juliamrch juliamrch approved these changes

Assignees

@davlgd davlgd

Labels
documentation Improvements or additions to documentation waiting Waiting from fixes or tests by submitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CC_DISABLE_BUILD_CACHE_UPLOAD environment variable
2 participants
@davlgd @juliamrch