Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CC_RUN_COMMAND + fix default callout in dark mode #123

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

juliamrch
Copy link
Collaborator

@juliamrch juliamrch commented Jan 2, 2024

Checklist

⚠️ If changes affect GitHub Action files

  • I have added tests to cover my changes : link

Pull request type

Please check the type of change your PR introduces:

  • Documentation content changes
  • Bugfix on the site: fix default callout on dark mode
  • Build related changes
  • Other (please describe):

Description

A summary of the changes

A note about CC_RUN_COMMAND with no effect on Docker instances has been added (ran myself into this issue a few days ago), as a default callout.

Took the opportunity to fix dark mode for default callouts.

Both changes can be compared here:

Why is this needed?

It's needed because otherwise, users will try to add CC_RUN_COMMAND to a Docker instance to fix deployment issues, but this won't have any effect and not debugging anything. It saves time for our users and discourages them to try this method and encourages them to use CMD in their Dockerfile instead.

Reviewes

Who should review these changes? @Bencaddyro

@juliamrch juliamrch added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 2, 2024
@juliamrch juliamrch added this to the Clear previous doc issues milestone Jan 2, 2024
@juliamrch juliamrch self-assigned this Jan 2, 2024
Copy link

github-actions bot commented Jan 2, 2024

Deployment has finished 👁️👄👁️ Your app is available here

Copy link

github-actions bot commented Jan 2, 2024

🚀 Your app has been updated and is available here

@Bencaddyro Bencaddyro merged commit 3c1ba4f into main Jan 2, 2024
3 checks passed
@Bencaddyro Bencaddyro deleted the cc-run-docker branch January 2, 2024 16:54
Copy link

github-actions bot commented Jan 2, 2024

Your review app has been deleted 👋

@Bencaddyro Bencaddyro linked an issue Jan 2, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

CC_RUN_COMMAND has no effect on Docker runtime
2 participants