Improve date handling for data pipeline #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no match is found for a year, others are being tried until a match is found or all years have been tested
|
Also added tile size increase to 512x512 pixels to this PR, ref #78 |
weiji14
approved these changes
Dec 7, 2023
scripts/datacube.py
Outdated
| pixels = [part.compute() for part in pixels] | ||
| print(f"Starting algorithm for MGRS tile {tile['name']} with index {index}") | ||
|
|
||
| # Shuffle years, use index as seed for reproducability but no |
There was a problem hiding this comment.
Suggested change
| # Shuffle years, use index as seed for reproducability but no | |
| # Shuffle years, use index as seed for reproducibility but no |
Like this the tile IDs in the file names should be consistent across dates.
|
Got this to work on batch and gave good results. Kicking off a new batch run as we speak, if all goes well we'll have 10x the data in a few hours 🤞🏽 |
|
Good timing! I'm hoping to kick off a new training run with Soumya's code later, and can test things out on the new data batch. |
3 tasks
brunosan
pushed a commit
that referenced
this pull request
Dec 27, 2023
* Improve date handling for data pipeline If no match is found for a year, others are being tried until a match is found or all years have been tested * Increase tile size to 512x512 pixels. Closes #78 * Increase dates per location to 3 Closes #79 * Prevent printing s3 sync upload progress logs * Move counter above cloud filter to ensure index consistency Like this the tile IDs in the file names should be consistent across dates. * Fix typo in comment * Update batch run setup to new bucket name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no match is found for a year, others are being tried until a match is found or all years have been tested
Closes #68