Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add org-slug and org-id flags to orb validate & process commands #922

Merged
merged 5 commits into from
Apr 28, 2023
Merged

Add org-slug and org-id flags to orb validate & process commands #922

merged 5 commits into from
Apr 28, 2023

Conversation

zbenhadi
Copy link
Contributor

@zbenhadi zbenhadi commented Apr 25, 2023 •
edited
Loading

Checklist

=========

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked for similar issues and haven't found anything relevant.
  • This is not a security issue (which should be reported here: https://circleci.com/security/)
  • I have read Contribution Guidelines.

Internal Checklist

  • I am requesting a review from my own team as well as the owning team
  • I have a plan in place for the monitoring of the changes that I am making (this can include new monitors, logs to be aware of, etc...)

Changes

=======

  • Added a new orbOrgOptions struct, to represent org-slug and org-id values
  • Added a new api package: collaborators - presents an interface with a single method "GetOrgCollaborations"
  • Changed "ValidateOrb" GQLQuery to include "ownerId" param, based on org-slug and org-id flags

Rationale

=========

Integrate the capability to validate an orb when using other private orbs from the same namespace.

@zbenhadi zbenhadi requested review from a team as code owners April 25, 2023 12:15
@zbenhadi zbenhadi force-pushed the DEVEX-856-circleci-orb-validate-fails-with-private-dependent-orb-from-same-namespace branch from 7b4e701 to 0f878f4 Compare April 25, 2023 12:20
@zbenhadi zbenhadi mentioned this pull request Apr 26, 2023
Closed
JulesFaucherre
JulesFaucherre suggested changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@JulesFaucherre JulesFaucherre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capture d’écran 2023-04-26 à 14 30 17
It seems the usage ask to use the <vcs-name>/<org-name> but the code only supports the <vcs-short>/<org-name> syntax

cmd/orb.go Outdated Show resolved Hide resolved
JulesFaucherre
JulesFaucherre approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@JulesFaucherre JulesFaucherre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very great job, thanks for also fixing the slug issue on config validate!

@zbenhadi zbenhadi force-pushed the DEVEX-856-circleci-orb-validate-fails-with-private-dependent-orb-from-same-namespace branch from 45a0812 to 34ea5bf Compare April 27, 2023 15:09
@zbenhadi zbenhadi merged commit d710994 into develop Apr 28, 2023
@zbenhadi zbenhadi deleted the DEVEX-856-circleci-orb-validate-fails-with-private-dependent-orb-from-same-namespace branch April 28, 2023 09:01
zbenhadi added a commit that referenced this pull request May 2, 2023
@zbenhadi @rlegan @JulesFaucherre
New Release (#924)
cc8c4de 
* Add warning on some CLI commands that orbs cannot be deleted once they are created

* Add org-slug and org-id flags to orb validate & process commands (#922)

---------

Co-authored-by: rlegan <legan.renaud@gmail.com>
Co-authored-by: JulesFaucherre <jules@circleci.com>
Co-authored-by: Renaud <45293016+rlegan@users.noreply.github.com>
This was referenced May 3, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulesFaucherre JulesFaucherre JulesFaucherre approved these changes

@KyleTryon KyleTryon KyleTryon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zbenhadi @JulesFaucherre @KyleTryon