Skip to content

Commit

Permalink
[RPP] Do not update trace window when mouse leaves insight table
Browse files Browse the repository at this point in the history
Bug: 371143933
Change-Id: I3225151c4d0f1431c0b41a8bfb5fdd636e4b851c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5908528
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
  • Loading branch information
Connor Clark authored and Devtools-frontend LUCI CQ committed Oct 4, 2024
1 parent 5a3efb5 commit cd48015
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
5 changes: 1 addition & 4 deletions front_end/panels/timeline/components/insights/Helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -134,14 +134,11 @@ export abstract class BaseInsight extends HTMLElement {
* This enables the hover/click table interactions.
*/
toggleTemporaryOverlays(
overlays: Overlays.Overlays.TimelineOverlay[]|null, options?: Overlays.Overlays.TimelineOverlaySetOptions): void {
overlays: Overlays.Overlays.TimelineOverlay[]|null, options: Overlays.Overlays.TimelineOverlaySetOptions): void {
if (!this.isActive()) {
return;
}

if (!options) {
options = {updateTraceWindow: true};
}
this.dispatchEvent(new SidebarInsight.InsightProvideOverlays(overlays ?? this.getInitialOverlays(), options));
}

Expand Down
2 changes: 1 addition & 1 deletion front_end/panels/timeline/components/insights/Table.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export class Table extends HTMLElement {
this.#insight.toggleTemporaryOverlays(overlays, {updateTraceWindow: !opts.isHover});
}
} else {
this.#insight.toggleTemporaryOverlays(null);
this.#insight.toggleTemporaryOverlays(null, {updateTraceWindow: false});
}

this.#state.selectedRowEl?.classList.remove('selected');
Expand Down

0 comments on commit cd48015

Please sign in to comment.