remove soft-fork 4 special cases #18407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
added
the
Changed
github-actions
bot
added
the
merge_conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
… default and remove the activation height and tests
arvidn
force-pushed
the
soft-fork4-activated
branch
from
e546eca
to
a071f40
Compare
github-actions
bot
removed
the
merge_conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
matt-o-how
approved these changes
Aug 12, 2024
emlowe
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that soft-fork 4 has activated, we can enable all its features by default and remove the activation height and tests
Purpose:
Simplify the code and run fewer tests by removing the soft-fork 4 logic. Since it has activated, we can now enable it for all block heights, removing test cases and special cases in the main consensus logic.
Current Behavior:
The consensus rules are different below and above the soft-fork 4 activation height.
pytestruns 8888 tests.New Behavior:
The consensus rules (related to soft fork 4) are the same at all block heights.
pytestruns 5789 tests.Testing Notes:
sync test is running here: