Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup a blsChanges submission test helping condition #5261

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Cleanup a blsChanges submission test helping condition #5261

merged 1 commit into from
Mar 13, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Mar 12, 2023

Cleanup a blsChanges submission test helping condition

@g11tech g11tech requested a review from a team as a code owner March 12, 2023 05:29
@g11tech g11tech enabled auto-merge (squash) March 12, 2023 05:29
@g11tech g11tech mentioned this pull request Mar 12, 2023
Closed
2 tasks
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 32c55a6 Previous: 27feb58 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 798.72 us/op 667.16 us/op 1.20
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 45.185 us/op 46.863 us/op 0.96
BLS verify - blst-native 1.1835 ms/op 1.2342 ms/op 0.96
BLS verifyMultipleSignatures 3 - blst-native 2.4103 ms/op 2.4719 ms/op 0.98
BLS verifyMultipleSignatures 8 - blst-native 5.3315 ms/op 5.3569 ms/op 1.00
BLS verifyMultipleSignatures 32 - blst-native 19.486 ms/op 19.124 ms/op 1.02
BLS aggregatePubkeys 32 - blst-native 25.727 us/op 25.484 us/op 1.01
BLS aggregatePubkeys 128 - blst-native 100.08 us/op 99.074 us/op 1.01
getAttestationsForBlock 52.931 ms/op 50.686 ms/op 1.04
isKnown best case - 1 super set check 260.00 ns/op 257.00 ns/op 1.01
isKnown normal case - 2 super set checks 258.00 ns/op 250.00 ns/op 1.03
isKnown worse case - 16 super set checks 256.00 ns/op 250.00 ns/op 1.02
CheckpointStateCache - add get delete 4.8930 us/op 5.0420 us/op 0.97
validate gossip signedAggregateAndProof - struct 2.7461 ms/op 2.7913 ms/op 0.98
validate gossip attestation - struct 1.3161 ms/op 1.3469 ms/op 0.98
pickEth1Vote - no votes 1.2517 ms/op 1.3477 ms/op 0.93
pickEth1Vote - max votes 9.2384 ms/op 11.183 ms/op 0.83
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.5888 ms/op 9.9599 ms/op 0.86
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 13.466 ms/op 16.777 ms/op 0.80
pickEth1Vote - Eth1Data fastSerialize value x2048 646.13 us/op 708.51 us/op 0.91
pickEth1Vote - Eth1Data fastSerialize tree x2048 6.7294 ms/op 5.1412 ms/op 1.31
bytes32 toHexString 489.00 ns/op 555.00 ns/op 0.88
bytes32 Buffer.toString(hex) 342.00 ns/op 424.00 ns/op 0.81
bytes32 Buffer.toString(hex) from Uint8Array 559.00 ns/op 595.00 ns/op 0.94
bytes32 Buffer.toString(hex) + 0x 343.00 ns/op 452.00 ns/op 0.76
Object access 1 prop 0.16600 ns/op 0.18000 ns/op 0.92
Map access 1 prop 0.15900 ns/op 0.17500 ns/op 0.91
Object get x1000 7.3230 ns/op 6.7100 ns/op 1.09
Map get x1000 0.61800 ns/op 0.64500 ns/op 0.96
Object set x1000 52.385 ns/op 55.293 ns/op 0.95
Map set x1000 44.781 ns/op 45.167 ns/op 0.99
Return object 10000 times 0.23640 ns/op 0.24790 ns/op 0.95
Throw Error 10000 times 4.2456 us/op 4.2911 us/op 0.99
fastMsgIdFn sha256 / 200 bytes 3.4440 us/op 3.5400 us/op 0.97
fastMsgIdFn h32 xxhash / 200 bytes 283.00 ns/op 293.00 ns/op 0.97
fastMsgIdFn h64 xxhash / 200 bytes 392.00 ns/op 408.00 ns/op 0.96
fastMsgIdFn sha256 / 1000 bytes 11.711 us/op 11.711 us/op 1.00
fastMsgIdFn h32 xxhash / 1000 bytes 423.00 ns/op 426.00 ns/op 0.99
fastMsgIdFn h64 xxhash / 1000 bytes 468.00 ns/op 468.00 ns/op 1.00
fastMsgIdFn sha256 / 10000 bytes 104.71 us/op 103.22 us/op 1.01
fastMsgIdFn h32 xxhash / 10000 bytes 1.9100 us/op 1.9540 us/op 0.98
fastMsgIdFn h64 xxhash / 10000 bytes 1.3310 us/op 1.4020 us/op 0.95
enrSubnets - fastDeserialize 64 bits 1.2870 us/op 1.3500 us/op 0.95
enrSubnets - ssz BitVector 64 bits 503.00 ns/op 513.00 ns/op 0.98
enrSubnets - fastDeserialize 4 bits 167.00 ns/op 191.00 ns/op 0.87
enrSubnets - ssz BitVector 4 bits 498.00 ns/op 570.00 ns/op 0.87
prioritizePeers score -10:0 att 32-0.1 sync 2-0 97.165 us/op 120.82 us/op 0.80
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 130.99 us/op 143.30 us/op 0.91
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 163.78 us/op 190.51 us/op 0.86
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 336.04 us/op 338.58 us/op 0.99
prioritizePeers score 0:0 att 64-1 sync 4-1 366.55 us/op 410.35 us/op 0.89
array of 16000 items push then shift 1.6158 us/op 1.7340 us/op 0.93
LinkedList of 16000 items push then shift 8.7800 ns/op 9.2490 ns/op 0.95
array of 16000 items push then pop 73.280 ns/op 116.67 ns/op 0.63
LinkedList of 16000 items push then pop 8.6000 ns/op 9.3770 ns/op 0.92
array of 24000 items push then shift 2.3268 us/op 2.4299 us/op 0.96
LinkedList of 24000 items push then shift 8.7590 ns/op 9.2290 ns/op 0.95
array of 24000 items push then pop 72.277 ns/op 86.400 ns/op 0.84
LinkedList of 24000 items push then pop 8.4630 ns/op 8.8820 ns/op 0.95
intersect bitArray bitLen 8 13.262 ns/op 13.611 ns/op 0.97
intersect array and set length 8 77.385 ns/op 82.574 ns/op 0.94
intersect bitArray bitLen 128 44.854 ns/op 44.549 ns/op 1.01
intersect array and set length 128 1.0429 us/op 1.1011 us/op 0.95
Buffer.concat 32 items 2.7270 us/op 2.7110 us/op 1.01
Uint8Array.set 32 items 2.7740 us/op 2.9890 us/op 0.93
pass gossip attestations to forkchoice per slot 3.6345 ms/op 2.3099 ms/op 1.57
computeDeltas 3.2120 ms/op 3.1386 ms/op 1.02
computeProposerBoostScoreFromBalances 1.9168 ms/op 1.8597 ms/op 1.03
altair processAttestation - 250000 vs - 7PWei normalcase 2.0498 ms/op 3.2352 ms/op 0.63
altair processAttestation - 250000 vs - 7PWei worstcase 3.2576 ms/op 5.0015 ms/op 0.65
altair processAttestation - setStatus - 1/6 committees join 130.18 us/op 155.06 us/op 0.84
altair processAttestation - setStatus - 1/3 committees join 261.54 us/op 288.80 us/op 0.91
altair processAttestation - setStatus - 1/2 committees join 350.24 us/op 387.00 us/op 0.91
altair processAttestation - setStatus - 2/3 committees join 459.74 us/op 498.23 us/op 0.92
altair processAttestation - setStatus - 4/5 committees join 642.48 us/op 692.40 us/op 0.93
altair processAttestation - setStatus - 100% committees join 752.56 us/op 814.37 us/op 0.92
altair processBlock - 250000 vs - 7PWei normalcase 17.857 ms/op 18.099 ms/op 0.99
altair processBlock - 250000 vs - 7PWei normalcase hashState 26.493 ms/op 31.701 ms/op 0.84
altair processBlock - 250000 vs - 7PWei worstcase 51.255 ms/op 55.225 ms/op 0.93
altair processBlock - 250000 vs - 7PWei worstcase hashState 66.752 ms/op 73.593 ms/op 0.91
phase0 processBlock - 250000 vs - 7PWei normalcase 1.9251 ms/op 2.6761 ms/op 0.72
phase0 processBlock - 250000 vs - 7PWei worstcase 26.769 ms/op 34.308 ms/op 0.78
altair processEth1Data - 250000 vs - 7PWei normalcase 449.24 us/op 567.59 us/op 0.79
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 6.5690 us/op 9.1610 us/op 0.72
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 19.161 us/op 30.056 us/op 0.64
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 8.3050 us/op 14.135 us/op 0.59
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 6.0860 us/op 12.000 us/op 0.51
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 74.530 us/op 119.15 us/op 0.63
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 609.55 us/op 706.87 us/op 0.86
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 898.27 us/op 992.35 us/op 0.91
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 838.64 us/op 905.89 us/op 0.93
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 2.3257 ms/op 2.4112 ms/op 0.96
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 1.4823 ms/op 1.4886 ms/op 1.00
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 3.7500 ms/op 5.1360 ms/op 0.73
Tree 40 250000 create 302.88 ms/op 409.28 ms/op 0.74
Tree 40 250000 get(125000) 178.98 ns/op 206.29 ns/op 0.87
Tree 40 250000 set(125000) 904.62 ns/op 1.2186 us/op 0.74
Tree 40 250000 toArray() 16.683 ms/op 24.781 ms/op 0.67
Tree 40 250000 iterate all - toArray() + loop 16.785 ms/op 23.022 ms/op 0.73
Tree 40 250000 iterate all - get(i) 64.180 ms/op 77.149 ms/op 0.83
MutableVector 250000 create 9.6521 ms/op 13.600 ms/op 0.71
MutableVector 250000 get(125000) 6.1190 ns/op 6.7450 ns/op 0.91
MutableVector 250000 set(125000) 233.76 ns/op 466.77 ns/op 0.50
MutableVector 250000 toArray() 2.6575 ms/op 4.9990 ms/op 0.53
MutableVector 250000 iterate all - toArray() + loop 2.8325 ms/op 4.3264 ms/op 0.65
MutableVector 250000 iterate all - get(i) 1.4928 ms/op 1.5763 ms/op 0.95
Array 250000 create 2.4862 ms/op 3.9952 ms/op 0.62
Array 250000 clone - spread 1.1383 ms/op 1.4000 ms/op 0.81
Array 250000 get(125000) 0.53800 ns/op 0.78700 ns/op 0.68
Array 250000 set(125000) 0.62200 ns/op 0.76400 ns/op 0.81
Array 250000 iterate all - loop 80.661 us/op 91.475 us/op 0.88
effectiveBalanceIncrements clone Uint8Array 300000 23.864 us/op 49.053 us/op 0.49
effectiveBalanceIncrements clone MutableVector 300000 351.00 ns/op 432.00 ns/op 0.81
effectiveBalanceIncrements rw all Uint8Array 300000 165.17 us/op 174.68 us/op 0.95
effectiveBalanceIncrements rw all MutableVector 300000 78.099 ms/op 96.804 ms/op 0.81
phase0 afterProcessEpoch - 250000 vs - 7PWei 111.10 ms/op 122.84 ms/op 0.90
phase0 beforeProcessEpoch - 250000 vs - 7PWei 42.428 ms/op 47.974 ms/op 0.88
altair processEpoch - mainnet_e81889 292.67 ms/op 394.56 ms/op 0.74
mainnet_e81889 - altair beforeProcessEpoch 47.255 ms/op 78.738 ms/op 0.60
mainnet_e81889 - altair processJustificationAndFinalization 16.165 us/op 23.849 us/op 0.68
mainnet_e81889 - altair processInactivityUpdates 5.1044 ms/op 8.5357 ms/op 0.60
mainnet_e81889 - altair processRewardsAndPenalties 52.680 ms/op 86.802 ms/op 0.61
mainnet_e81889 - altair processRegistryUpdates 2.6490 us/op 3.4940 us/op 0.76
mainnet_e81889 - altair processSlashings 526.00 ns/op 1.1190 us/op 0.47
mainnet_e81889 - altair processEth1DataReset 565.00 ns/op 988.00 ns/op 0.57
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.1969 ms/op 2.0277 ms/op 0.59
mainnet_e81889 - altair processSlashingsReset 4.8720 us/op 7.2720 us/op 0.67
mainnet_e81889 - altair processRandaoMixesReset 4.5510 us/op 7.5800 us/op 0.60
mainnet_e81889 - altair processHistoricalRootsUpdate 681.00 ns/op 1.1290 us/op 0.60
mainnet_e81889 - altair processParticipationFlagUpdates 2.4160 us/op 6.0800 us/op 0.40
mainnet_e81889 - altair processSyncCommitteeUpdates 570.00 ns/op 1.0120 us/op 0.56
mainnet_e81889 - altair afterProcessEpoch 117.99 ms/op 138.64 ms/op 0.85
phase0 processEpoch - mainnet_e58758 314.89 ms/op 447.95 ms/op 0.70
mainnet_e58758 - phase0 beforeProcessEpoch 120.84 ms/op 200.36 ms/op 0.60
mainnet_e58758 - phase0 processJustificationAndFinalization 17.937 us/op 28.329 us/op 0.63
mainnet_e58758 - phase0 processRewardsAndPenalties 53.259 ms/op 77.967 ms/op 0.68
mainnet_e58758 - phase0 processRegistryUpdates 7.4350 us/op 18.453 us/op 0.40
mainnet_e58758 - phase0 processSlashings 524.00 ns/op 1.1640 us/op 0.45
mainnet_e58758 - phase0 processEth1DataReset 517.00 ns/op 1.0810 us/op 0.48
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 941.03 us/op 1.8260 ms/op 0.52
mainnet_e58758 - phase0 processSlashingsReset 3.3690 us/op 7.9510 us/op 0.42
mainnet_e58758 - phase0 processRandaoMixesReset 4.5050 us/op 10.833 us/op 0.42
mainnet_e58758 - phase0 processHistoricalRootsUpdate 665.00 ns/op 1.2530 us/op 0.53
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.9760 us/op 8.1320 us/op 0.49
mainnet_e58758 - phase0 afterProcessEpoch 93.758 ms/op 115.24 ms/op 0.81
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2329 ms/op 2.1488 ms/op 0.57
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4479 ms/op 2.6929 ms/op 0.54
altair processInactivityUpdates - 250000 normalcase 19.331 ms/op 28.616 ms/op 0.68
altair processInactivityUpdates - 250000 worstcase 21.602 ms/op 34.103 ms/op 0.63
phase0 processRegistryUpdates - 250000 normalcase 6.1400 us/op 14.054 us/op 0.44
phase0 processRegistryUpdates - 250000 badcase_full_deposits 229.56 us/op 323.89 us/op 0.71
phase0 processRegistryUpdates - 250000 worstcase 0.5 126.74 ms/op 148.43 ms/op 0.85
altair processRewardsAndPenalties - 250000 normalcase 48.280 ms/op 74.460 ms/op 0.65
altair processRewardsAndPenalties - 250000 worstcase 56.400 ms/op 77.564 ms/op 0.73
phase0 getAttestationDeltas - 250000 normalcase 6.5601 ms/op 7.2291 ms/op 0.91
phase0 getAttestationDeltas - 250000 worstcase 6.4343 ms/op 8.0830 ms/op 0.80
phase0 processSlashings - 250000 worstcase 3.5383 ms/op 4.0580 ms/op 0.87
altair processSyncCommitteeUpdates - 250000 167.54 ms/op 208.61 ms/op 0.80
BeaconState.hashTreeRoot - No change 262.00 ns/op 271.00 ns/op 0.97
BeaconState.hashTreeRoot - 1 full validator 51.415 us/op 55.037 us/op 0.93
BeaconState.hashTreeRoot - 32 full validator 519.70 us/op 531.61 us/op 0.98
BeaconState.hashTreeRoot - 512 full validator 4.8439 ms/op 6.9407 ms/op 0.70
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 62.365 us/op 73.808 us/op 0.84
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 916.00 us/op 1.0175 ms/op 0.90
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 11.251 ms/op 12.876 ms/op 0.87
BeaconState.hashTreeRoot - 1 balances 48.197 us/op 52.376 us/op 0.92
BeaconState.hashTreeRoot - 32 balances 432.99 us/op 503.76 us/op 0.86
BeaconState.hashTreeRoot - 512 balances 4.2455 ms/op 4.8631 ms/op 0.87
BeaconState.hashTreeRoot - 250000 balances 74.967 ms/op 73.326 ms/op 1.02
aggregationBits - 2048 els - zipIndexesInBitList 15.785 us/op 27.603 us/op 0.57
regular array get 100000 times 34.262 us/op 35.883 us/op 0.95
wrappedArray get 100000 times 33.835 us/op 34.925 us/op 0.97
arrayWithProxy get 100000 times 15.406 ms/op 15.939 ms/op 0.97
ssz.Root.equals 651.00 ns/op 608.00 ns/op 1.07
byteArrayEquals 630.00 ns/op 595.00 ns/op 1.06
shuffle list - 16384 els 6.8110 ms/op 7.5334 ms/op 0.90
shuffle list - 250000 els 99.607 ms/op 110.30 ms/op 0.90
processSlot - 1 slots 8.7300 us/op 9.8230 us/op 0.89
processSlot - 32 slots 1.2997 ms/op 1.5569 ms/op 0.83
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 182.77 us/op 211.46 us/op 0.86
getCommitteeAssignments - req 1 vs - 250000 vc 2.7879 ms/op 2.9753 ms/op 0.94
getCommitteeAssignments - req 100 vs - 250000 vc 4.0036 ms/op 4.2834 ms/op 0.93
getCommitteeAssignments - req 1000 vs - 250000 vc 4.3129 ms/op 4.5836 ms/op 0.94
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.3300 ns/op 5.3400 ns/op 0.81
state getBlockRootAtSlot - 250000 vs - 7PWei 926.33 ns/op 821.72 ns/op 1.13
computeProposers - vc 250000 10.154 ms/op 11.525 ms/op 0.88
computeEpochShuffling - vc 250000 98.485 ms/op 108.40 ms/op 0.91
getNextSyncCommittee - vc 250000 168.13 ms/op 186.54 ms/op 0.90

by benchmarkbot/action

@philknows philknows added this to the v1.6.0 milestone Mar 12, 2023
@g11tech g11tech merged commit dc5f2ed into unstable Mar 13, 2023
@g11tech g11tech deleted the g11tech/remove-blschanges-testhelper branch March 13, 2023 01:43
twoeths pushed a commit that referenced this pull request Mar 20, 2023
@g11tech @twoeths
Cleanup a blsChanges submission test helping condition (#5261)
bd0f28a
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.6.0 🎉

@wemeetagain
Copy link
Member

🎉 This PR is included in v1.7.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@g11tech @wemeetagain @dapplion @philknows