Skip to content

Commit

Permalink
Add cli option to disable attestation service grouping optimization
Browse files Browse the repository at this point in the history
  • Loading branch information
nflaig committed Mar 13, 2023
1 parent eb14c77 commit 0362077
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 1 deletion.
1 change: 1 addition & 0 deletions packages/cli/src/cmds/validator/handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ export async function validatorHandler(args: IValidatorCliArgs & GlobalArgs): Pr
doppelgangerProtectionEnabled,
afterBlockDelaySlotFraction: args.afterBlockDelaySlotFraction,
scAfterBlockDelaySlotFraction: args.scAfterBlockDelaySlotFraction,
disableAttestationGrouping: args.disableAttestationGrouping,
valProposerConfig,
},
metrics
Expand Down
9 changes: 9 additions & 0 deletions packages/cli/src/cmds/validator/options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export type IValidatorCliArgs = AccountValidatorArgs &
graffiti: string;
afterBlockDelaySlotFraction?: number;
scAfterBlockDelaySlotFraction?: number;
disableAttestationGrouping?: boolean;
suggestedFeeRecipient?: string;
proposerSettingsFile?: string;
strictFeeRecipientCheck?: boolean;
Expand Down Expand Up @@ -189,6 +190,14 @@ export const validatorOptions: CliCommandOptions<IValidatorCliArgs> = {
type: "number",
},

disableAttestationGrouping: {
hidden: true,
description:
"Disables attestation service grouping optimization, attestation tasks will be executed per committee instead of just once for all committees.",
default: false,
type: "boolean",
},

proposerSettingsFile: {
description:
"A yaml file to specify detailed default and per validator pubkey customized proposer configs. PS: This feature and its format is in alpha and subject to change",
Expand Down
6 changes: 5 additions & 1 deletion packages/validator/src/validator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export type ValidatorOptions = {
abortController: AbortController;
afterBlockDelaySlotFraction?: number;
scAfterBlockDelaySlotFraction?: number;
disableAttestationGrouping?: boolean;
doppelgangerProtectionEnabled?: boolean;
closed?: boolean;
valProposerConfig?: ValidatorProposerConfig;
Expand Down Expand Up @@ -123,7 +124,10 @@ export class Validator {
emitter,
chainHeaderTracker,
metrics,
{afterBlockDelaySlotFraction: opts.afterBlockDelaySlotFraction}
{
afterBlockDelaySlotFraction: opts.afterBlockDelaySlotFraction,
disableAttestationGrouping: opts.disableAttestationGrouping,
}
);

this.syncCommitteeService = new SyncCommitteeService(
Expand Down

0 comments on commit 0362077

Please sign in to comment.