-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pkg/trie): Add TrieCache for trie values and nodes #3895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o/read-only-triedb
…o/read-only-triedb
…r into diego/triedb-iterator
timwu20
reviewed
May 9, 2024
EclesioMeloJunior
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
timwu20
reviewed
May 10, 2024
timwu20
reviewed
May 16, 2024
timwu20
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces a
TrieCache
an LRU cache to reduce latency during trie lookups.This implementation represents the simplest form of cache. In the future, we could consider a more complex one like parity does using different caches for different purposes, such as
SharedTrieCache
,LocalTrieCache
, andTrieCache
.These could serve as inspiration for future enhancements to our caching strategy.
For further details, see Parity's cache implementation.
Summary of changes
TrieCache
interfaceTrieCache
inTrieDB
Tests
make test
Benchmarks
Issues
closes: #3623
Primary Reviewer
@EclesioMeloJunior