Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(pkg/trie): Implement trie nodes / values cache #3623

Closed
Tracked by #3639
, #3805
...
dimartiro opened this issue Dec 5, 2023 · 0 comments · Fixed by #3895
Closed
Tracked by #3639
, #3805
...

(pkg/trie): Implement trie nodes / values cache #3623

dimartiro opened this issue Dec 5, 2023 · 0 comments · Fixed by #3895
Assignees
@dimartiro
Labels
C-complex Complex changes across multiple modules. Possibly will require additional research. S-trie issues related to the pkg/trie package. T-feat this issue/pr is a new feature or functionality.

Comments

@dimartiro
Copy link
Contributor

dimartiro commented Dec 5, 2023 •
edited
Loading

In order to reduce the amount of memory used by our servers we have to implement a cache to prevent having 100% of the tries in memory.

This will be used with the lazy loading to have the most frequently used tries into the cached and improve the read times

External resources:

Substrate impl
@dimartiro dimartiro self-assigned this Dec 5, 2023
This was referenced Dec 5, 2023
Closed
Open
@dimartiro dimartiro changed the title lib/trie: Implement LRU cache lib/trie: Implement trie nodes / values cache Dec 5, 2023
@dimartiro dimartiro mentioned this issue Dec 12, 2023
Closed
4 tasks
@P1sar P1sar removed trie labels Jan 15, 2024
@dimartiro dimartiro added the C-complex Complex changes across multiple modules. Possibly will require additional research. label Jan 18, 2024
@dimartiro dimartiro changed the title lib/trie: Implement trie nodes / values cache trie: Implement trie nodes / values cache Jan 18, 2024
@P1sar P1sar added the S-trie issues related to the pkg/trie package. label Jan 18, 2024
@P1sar P1sar added this to the Full Node MVP milestone Jan 18, 2024
@dimartiro dimartiro changed the title trie: Implement trie nodes / values cache (pkg/trie): Implement trie nodes / values cache Mar 21, 2024
@dimartiro dimartiro added the T-enhancement this issue/pr covers improvement of existing functionality. label Mar 21, 2024
@dimartiro dimartiro mentioned this issue Mar 21, 2024
Closed
5 tasks
@dimartiro dimartiro removed this from the Full Node MVP milestone Apr 4, 2024
@dimartiro dimartiro mentioned this issue Apr 16, 2024
Merged
6 tasks
@dimartiro dimartiro added T-feat this issue/pr is a new feature or functionality. and removed T-enhancement this issue/pr covers improvement of existing functionality. labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimartiro dimartiro

Labels
C-complex Complex changes across multiple modules. Possibly will require additional research. S-trie issues related to the pkg/trie package. T-feat this issue/pr is a new feature or functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pkg/trie): Add TrieCache for trie values and nodes ChainSafe/gossamer
2 participants
@dimartiro @P1sar